Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Fix for 25936 #26237

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Added Fix for 25936 #26237

merged 1 commit into from
Jan 8, 2020

Conversation

divyajyothi5321
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Regular Price Label Alignment Issues in Frontend #25936: Regular Price Label Alignment Issues in Frontend

Manual testing scenarios (*)

  1. Admin->Catalog->Products->Add Product
  2. Add Price ex:$20
  3. Click on Advanced Pricing and add regular price ex:$10
  4. Save the product
  5. Open product in frontend
  6. With this fix advanced pricing aligned in single line

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @divyajyothi5321. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@aleron75
Copy link
Contributor

aleron75 commented Jan 3, 2020

@magento give me test instance

@aleron75
Copy link
Contributor

aleron75 commented Jan 3, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @aleron75. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @aleron75. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@aleron75 aleron75 self-assigned this Jan 3, 2020
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, here is your Magento instance.
Admin access: https://i-26237-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@aleron75
Copy link
Contributor

aleron75 commented Jan 3, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @aleron75. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, here is your new Magento instance.
Admin access: https://pr-26237.instances.magento-community.engineering/admin
Login: admin Password: 123123q

aleron75
aleron75 approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@aleron75 aleron75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the fix on Chrome 79.0.3945.88 (Linux), see screenshot below:

Workspace 1_010

@aleron75 aleron75 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 3, 2020
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6534 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jan 3, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@ghost ghost added the Progress: accept label Jan 3, 2020
@dmytro-ch dmytro-ch mentioned this pull request Jan 3, 2020
Closed
4 tasks
@ghost ghost assigned ptylek Jan 8, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6534 has been created to process this Pull Request

@VladimirZaets VladimirZaets mentioned this pull request Jan 8, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 8, 2020
@VladimirZaets
ENGCOM-6534: Added Fix for 25936 #26237
a58ad00
@magento-engcom-team magento-engcom-team merged commit c39e85c into magento:2.4-develop Jan 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @divyajyothi5321, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

@ptylek ptylek ptylek approved these changes

@kanthy-i95dev kanthy-i95dev Awaiting requested review from kanthy-i95dev

Assignees

@aleron75 aleron75

@ptylek ptylek

@engcom-Delta engcom-Delta

Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@divyajyothi5321 @aleron75 @magento-engcom-team @engcom-Delta @ptylek @dmytro-ch