Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #22964 #26270

Merged
merged 7 commits into from
Jan 9, 2020
Merged

Fix #22964 #26270

merged 7 commits into from
Jan 9, 2020

Conversation

marcoaacoliveira
Copy link
Member

@marcoaacoliveira marcoaacoliveira commented Jan 5, 2020 •
edited
Loading

Description (*)

It was need to change the appendTimeIfNeeded, because isn't a good practice to transform DateTime without hour into DateTime with hour just appending a string in the end of other string.

Fixed Issues (if relevant)

  1. Unable to save any dates if the user interface locale is not english (US) in 2.3.1 #22964: Unable to save any dates if the user interface locale is not english (US) in 2.3.1

Manual testing scenarios (*)

  1. Change interface to Greek locale
  2. Go to product (create or edit one)
  3. Try to save one date attribute

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@marcoaacoliveira
Solving magento#22964
bb16e33 
It was needed to change the appendTimeIfNeeded, because isn't right to transform DateTime without hour into with hour just appending a string in the end of other string.
@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2020

Hi @marcoaacoliveira. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@marcoaacoliveira
Copy link
Member Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @marcoaacoliveira. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @marcoaacoliveira, here is your Magento instance.
Admin access: https://i-26270-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@marcoaacoliveira
Copy link
Member Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @marcoaacoliveira. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @marcoaacoliveira, here is your new Magento instance.
Admin access: https://pr-26270.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@marcoaacoliveira marcoaacoliveira changed the title [WIP] Solving #22964 Solving #22964 Jan 5, 2020
@marcoaacoliveira
Copy link
Member Author

@magento give me test instance

@marcoaacoliveira marcoaacoliveira mentioned this pull request Jan 6, 2020
Closed
@marcoaacoliveira marcoaacoliveira changed the title Solving #22964 Fix #22964 Jan 6, 2020
@ghost ghost assigned aleron75 Jan 8, 2020
@aleron75 aleron75 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 8, 2020
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6552 has been created to process this Pull Request

@marcoaacoliveira
Copy link
Member Author

@aleron75 Thanks a lot for reviewing it. May we have some of those awards labels for this one?

@engcom-Alfa engcom-Alfa self-assigned this Jan 8, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 8, 2020
magento-engcom-team pushed a commit that referenced this pull request Jan 9, 2020
@VladimirZaets
ENGCOM-6552: Fix #22964 #26270
70aefe6
@magento-engcom-team magento-engcom-team merged commit c85410d into magento:2.4-develop Jan 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @marcoaacoliveira, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

@joni-jones joni-jones Awaiting requested review from joni-jones

Assignees

@aleron75 aleron75

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Stdlib Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoaacoliveira @magento-engcom-team @engcom-Alfa @aleron75 @engcom-Foxtrot