Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ObjectManager usage - Magento_Bundle #26397

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Cleanup ObjectManager usage - Magento_Bundle #26397

merged 3 commits into from
Apr 2, 2020

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Jan 15, 2020 •
edited
Loading

Description (*)

This PR cleanups ObjectManager usage in Magento_Bundle, adds additional dependencies with backward compatibility to api classes, and removes object manager instantiation from non-api classes

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 15, 2020

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Jan 15, 2020
@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_bundle branch 3 times, most recently from 3de05a6 to 331687e Compare January 15, 2020 12:31
@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_bundle branch 2 times, most recently from 2e374b1 to 8274412 Compare February 22, 2020 23:12
@Bartlomiejsz
Copy link
Contributor Author

@magento-engcom-team not sure why Unit Tests are marked as failing since there are no failures in Allure report for neither CE, EE or B2B

@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_bundle branch from 8274412 to f05629f Compare February 26, 2020 09:42
@Bartlomiejsz Bartlomiejsz added the WIP Work In Progress label Feb 28, 2020
@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_bundle branch from f05629f to c024c04 Compare March 1, 2020 23:01
@Bartlomiejsz Bartlomiejsz changed the title Move additional dependencies from private getters to constructor - Magento_Bundle Cleanup ObjectManager usage - Magento_Bundle Mar 1, 2020
@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_bundle branch from c024c04 to ec09477 Compare March 3, 2020 09:16
@ihor-sviziev ihor-sviziev self-assigned this Mar 21, 2020
@ihor-sviziev ihor-sviziev added Cleanup Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Mar 21, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Unit Tests

@ihor-sviziev
Copy link
Contributor

@Bartlomiejsz I believe it's already ready for review?

@Bartlomiejsz
Copy link
Contributor Author

Hi @ihor-sviziev to be honest I'm not sure, I'll try to verify later today if there are any other occurrences to be fixed in this module and will let you know

@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_bundle branch from ec09477 to e535d37 Compare March 21, 2020 16:18
@Bartlomiejsz
Copy link
Contributor Author

Hi @ihor-sviziev, I added some additional changes, once the tests are passed will be ready for review

@Bartlomiejsz Bartlomiejsz removed the WIP Work In Progress label Mar 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7170 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Mar 27, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Mar 27, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Echo
Copy link
Contributor

Failed unit tests not related to the changes in this PR

magento-engcom-team pushed a commit that referenced this pull request Apr 2, 2020
@slavvka
ENGCOM-7170: Cleanup ObjectManager usage - Magento_Bundle #26397
aac4e8c
@magento-engcom-team magento-engcom-team merged commit cc7aece into magento:2.4-develop Apr 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 2, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/dependencies_into_constructor_bundle branch June 23, 2020 20:44
rain2o added a commit to rain2o/magento2 that referenced this pull request Aug 21, 2020
@rain2o
Cleanup changes from PR magento#26397
56ef44b
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Braintree Component: Bundle Component: Newsletter Component: WeeeGraphQl Component: WishlistGraphQl Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bartlomiejsz @ihor-sviziev @magento-engcom-team @engcom-Alfa @engcom-Echo