Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#895 Fix for Media Gallery buttons are shifted to the left #26413

Conversation

diazwatson
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. [Bug] Media Gallery buttons are shifted to the left adobe-stock-integration#895: [Bug] Media Gallery buttons are shifted to the left

Manual testing scenarios (*)

  1. Login to Admin Panel
  2. Open Media Gallery (i.e. Catalog -> Category -> Content -> Select From Media Gallery button)

Expected result (*)

Media gallery buttons should be aligned to the right

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 16, 2020

Hi @diazwatson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner labels Jan 16, 2020
@diazwatson diazwatson added Partner: Maginus Partner Maginus contribution and removed Partner: Space 48 Partner Space48 contribution labels Jan 16, 2020
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @diazwatson ! I think that the styles should be updated in the app/design/adminhtml/Magento/backend/Magento_Cms/web/css/source/_module.less (where all exiting media gallery styles are defined) for consistency.

The Media Gallery module is rather a backend module for working with media files that will be used for the NEW media gallery and this particular fix is for the old media gallery.

@diazwatson
Copy link
Contributor Author

Thanks for the explanation @sivaschenko 👍

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-6664 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 22, 2020
@engcom-Delta engcom-Delta self-assigned this Jan 23, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Partner: Maginus Partner Maginus contribution partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants