Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAG-251090-26590: Fixed Customer registration multiple form submit #26642

Merged
merged 2 commits into from
Mar 12, 2020
Merged

MAG-251090-26590: Fixed Customer registration multiple form submit #26642

merged 2 commits into from
Mar 12, 2020

Conversation

princeantil90
Copy link

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Customer registration multiple form submit #26590: Customer registration multiple form submit

Manual testing scenarios (*)

  1. From the Storefront, Create a new account (customer/account/create/ URL)
  2. Fill in all the required fields.
  3. Click the "Create an Account" button multiple times really fast.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2020

Hi @princeCB. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@princeantil90
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @princeCB. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @princeCB, here is your new Magento instance.
Admin access: https://pr-26642.instances.magento-community.engineering/admin_a8f1
Login: 37da9acf Password: d7ceb8a6eea7
Instance will be terminated in up to 3 hours.

@princeantil90 princeantil90 mentioned this pull request Feb 2, 2020
Closed
@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 2, 2020

@magento run Functional Tests CE

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 2, 2020

@magento run Functional Tests EE

@rogyar rogyar mentioned this pull request Feb 2, 2020
Closed
4 tasks
@ihor-sviziev ihor-sviziev self-assigned this Mar 4, 2020
@ihor-sviziev
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, here is your new Magento instance.
Admin access: https://pr-26642.instances.magento-community.engineering/admin_f218
Login: 33a97d88 Password: 5a806ec3f5bb
Instance will be terminated in up to 3 hours.

@ihor-sviziev
Copy link
Contributor

@magento run Static Tests

@ghost ghost added the Progress: review label Mar 4, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 4, 2020
@ihor-sviziev
Copy link
Contributor

I think it will be really hard to cover these changes with tests, so I put "auto-test: not required" label

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7034 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@princeCB thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Mar 4, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 5, 2020
magento-engcom-team pushed a commit that referenced this pull request Mar 12, 2020
@slavvka
ENGCOM-7034: MAG-251090-26590: Fixed Customer registration multiple f…
c55b082 
…orm submit #26642
@magento-engcom-team magento-engcom-team merged commit a73f036 into magento:2.4-develop Mar 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @princeCB, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@magento-engcom-team magento-engcom-team Awaiting requested review from magento-engcom-team

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Customer Event: mm20in Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@princeantil90 @magento-engcom-team @sdzhepa @ihor-sviziev @engcom-Alfa @rav-redchamps @engcom-Charlie @princeCB