Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open separate page when click 'View' in CMS pages(Grid) #26907

Conversation

dominicfernando
Copy link
Contributor

Goto -> Admin -> Content -> Pages and click 'View' in grid.
The preview page will open in a separate view.

Selection_078

@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2020

Hi @dominicfernando. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Cms Release Line: 2.4 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Feb 18, 2020
@eduard13 eduard13 self-assigned this Feb 18, 2020
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dominicfernando, thank you for the improvement. According to the last updates to the definition of done all changes should be covered by automated tests.

I suggest trying to update the following unit test Magento\Cms\Test\Unit\Ui\Component\Listing\Column\PageActionsTest by including your case.
Thank you.

@ghost ghost unassigned eduard13 Feb 18, 2020
@magento magento deleted a comment from m2-assistant bot Feb 18, 2020
@cspruiell
Copy link
Contributor

@tkacheva Please provide product approval for this change.

@ghost ghost assigned tkacheva Feb 18, 2020
@eduard13
Copy link
Contributor

Hi @dominicfernando, looks like the opening the page in a new tab is causing the functional tests failing. May I ask you to adjust the MFTF tests accordingly to your changes and also fix the static tests?
You may try using the following action:
<switchToNextTab stepKey="switchToNextTab"/>

Thank you.

@engcom-Echo
Copy link
Contributor

I will try to fix tests

@ghost ghost assigned eduard13 Feb 27, 2020
@eduard13 eduard13 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7001 has been created to process this Pull Request
✳️ @eduard13, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Mar 2, 2020

Hi @dominicfernando, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Cms Component: Widget Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants