-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open separate page when click 'View' in CMS pages(Grid) #26907
Open separate page when click 'View' in CMS pages(Grid) #26907
Conversation
Hi @dominicfernando. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dominicfernando, thank you for the improvement. According to the last updates to the definition of done all changes should be covered by automated tests.
I suggest trying to update the following unit test Magento\Cms\Test\Unit\Ui\Component\Listing\Column\PageActionsTest
by including your case.
Thank you.
@tkacheva Please provide product approval for this change. |
Hi @dominicfernando, looks like the opening the page in a new tab is causing the functional tests failing. May I ask you to adjust the MFTF tests accordingly to your changes and also fix the static tests? Thank you. |
I will try to fix tests |
Hi @eduard13, thank you for the review.
|
✔️ QA passed |
Hi @dominicfernando, thank you for your contribution! |
Goto -> Admin -> Content -> Pages and click 'View' in grid.
The preview page will open in a separate view.