Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 27009: Fix error fire on catch when create new theme #27026

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

vincentle89
Copy link
Contributor

@vincentle89 vincentle89 commented Feb 26, 2020

Missing variable outside CATCH causing a double-fault in Renderer.php
Issue: #27009

Description (*)

Declare a variable to avoid firing on an exception

Fixed Issues (if relevant)

  1. Missing variable outside CATCH causing a double-fault in Renderer.php  #27009: Missing variable outside CATCH causing a double-fault in Renderer.php

Manual testing scenarios (*)

  1. Create a new Theme, with web/css folder empty inside.

  2. Create your default.xml and catalog_product_view.xml

  3. Access to pages and see if there are any exceptions

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @vincent-le89. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cover that with Unit Test?

  1. Happy flow (Success)
  2. Fixed case (Failure)

@vincentle89
Copy link
Contributor Author

2. Fixed case (Failure)

@lbajsarowicz I think this doesn't need a united test. It is only a simple change.
I can't covert that with a unit test

@ihor-sviziev ihor-sviziev removed their request for review February 26, 2020 10:43
@vincentle89 vincentle89 removed the request for review from Nazar65 February 27, 2020 03:25
@ghost
Copy link

ghost commented Feb 27, 2020

@vincent-le89 unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@vincentle89
Copy link
Contributor Author

Hi @ihor-sviziev

Please help me to check this pull request. I think that it's simple to create a unit test.
Thanks

@vincentle89 vincentle89 dismissed lbajsarowicz’s stale review February 27, 2020 03:31

Only add a variable to avoid exception in catch

@ghost
Copy link

ghost commented Feb 27, 2020

@vincent-le89 unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@vincentle89 vincentle89 requested review from lbajsarowicz and removed request for lbajsarowicz February 27, 2020 03:33
@ghost ghost unassigned ihor-sviziev Feb 27, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s not cover it with test as it will be too hard. I thought it’s public

@ghost ghost assigned ihor-sviziev Mar 5, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Mar 5, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing functional tests not related to changes from this PR

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7052 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7052 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @vincent-le89, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing variable outside CATCH causing a double-fault in Renderer.php
7 participants