-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Create Account tests (Success & Failure) with extend
#27274
MFTF: Create Account tests (Success & Failure) with extend
#27274
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed |
Failed functional tests not related to the changes in this PR |
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
The previous test for Create Customer account was based on single ActionGroup that does everything at once. As ActionGroups should have singular responsibility, I used different set.
By the way, I've changed the Failure example to show the best practices when it comes to extending existing tests, to slightly change their behaviour.
Replaced
customer
that was unclear where it comes from tocreateCustomer
to show up, that everytime whencreateCustomer
is being used, it means that we refer to stepKeyRelated Pull Requests
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
vendor/bin/mftf run:test -r StorefrontCreateCustomerTest StorefrontCreateExistingCustomerTest
Questions or comments
CC: @okolesnyk
Contribution checklist (*)