Fix duplicated footer in Magento_Customer emails

[ptylek]

Description (*)

Email templates for change email, change email and password, password reset have duplicated Thank you note which is already in the footer:

<td class="footer">
    <p class="closing">{{trans "Thank you, %store_name" store_name=$store.frontend_name}}!</p>
</td>

and footer template is imported.

Fixing this will remove duplicated content in email.

Related Pull Requests

Fixed Issues (if relevant)

Couldn't find any issues, maybe there is some.

Manual testing scenarios (*)

1. As a logged in user go to User Area - My Account Information section and change password / email.
2. Go to your email box and check those emails.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix duplicated footer in Magento_Customer emails #28433: Fix duplicated footer in Magento_Customer emails

[m2-assistant]

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi @ptylek. Thank you for your collaboration. We could cover this part with an integration test in a similar way as we do here. However, covering templates not a common case for auto-tests. I believe we can skip it for now.

[rogyar]

Failing tests are not related to the current changes

A potential issue spotted

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7177 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[lbajsarowicz]

I would like to cover that with tests, but actually both footers are slightly different and it does not make sense to cover this specific case. The other two cases were covered:

• Test coverage for PR #27357 (E-mail templates) #27609
• Test coverage for PR #27589 (E-mail templates) #27606

[ptylek]

@rogyar do you know any update for this PR? As @lbajsarowicz suggested, it does not make sense to cover this specific case.

[VladimirZaets]

Hi @ptylek . Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. In this case, I think it can be covered by an integration test. Can you do it?

[ptylek]

Hi @ptylek . Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. In this case, I think it can be covered by an integration test. Can you do it?

@VladimirZaets I didn't know how to approach this issue with tests. I asked @lbajsarowicz and he advised

I would like to cover that with tests, but actually both footers are slightly different and it does not make sense to cover this specific case.

If there are any issues, maybe this change can be marked as cleanup.

[VladimirZaets]

@magento create issue

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7177 has been created to process this Pull Request

[m2-assistant]

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.