Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage for PR #27357 (E-mail templates) #27609

Merged
merged 8 commits into from
Sep 2, 2020
Merged

Test coverage for PR #27357 (E-mail templates) #27609

merged 8 commits into from
Sep 2, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Apr 5, 2020 •
edited
Loading

Description (*)

Additional Integration Tests coverage for PR provided by @ptylek

Related Pull Requests

Fixed Issues (if relevant)

  1. Newsletter subscription emails should also use paragraph tags #27357

Manual testing scenarios (*)

  1. ...
  2. ...

Support

Solving this issue is supported by Mediotype

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 5, 2020
@lbajsarowicz lbajsarowicz mentioned this pull request Apr 5, 2020
Merged
5 tasks
@rogyar rogyar self-assigned this Apr 5, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 20, 2020
rogyar
rogyar previously approved these changes Apr 20, 2020
View reviewed changes
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7461 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 21, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 21, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 21, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 21, 2020
@slavvka slavvka moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-7461 has been created to process this Pull Request

@slavvka slavvka moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard May 20, 2020
@slavvka slavvka added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 20, 2020
@ptylek ptylek mentioned this pull request May 21, 2020
Merged
5 tasks
@VladimirZaets VladimirZaets moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard May 27, 2020
@VladimirZaets VladimirZaets added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed Progress: accept QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels May 27, 2020
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Just to make sure that nothing was broken in the meantime.

@ihor-sviziev
Copy link
Contributor

@slavvka @VladimirZaets is there any reasons why this PR isn't getting merged?

@sidolov sidolov removed this from the 2.4.1 milestone Aug 20, 2020
@ihor-sviziev
Copy link
Contributor

Progress:accept label just disappeared. I just fixed it

magento-engcom-team pushed a commit that referenced this pull request Sep 2, 2020
@sidolov
ENGCOM-7461: Test coverage for PR #27357 (E-mail templates) #27609
ced8102
@magento-engcom-team magento-engcom-team merged commit 02d6f96 into magento:2.4-develop Sep 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka approved these changes

@rogyar rogyar rogyar left review comments

Assignees

@rogyar rogyar

@slavvka slavvka

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Event: Global-Contribution-Day Partner: Blue Acorn iCi Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@lbajsarowicz @magento-engcom-team @engcom-Alfa @ihor-sviziev @rogyar @slavvka @VladimirZaets @sidolov @lenaorobei @engcom-Echo