improve exception handling in Layout render

[fsw]

Description (*)

When layout is being rendered in production mode, all exception messages are logged to system log as critical issues. However exception stack is lost. If we pass exception to LoggerInterface::critical instead this data will be saved to var/report.

Manual testing scenarios (*)

1. Add throw \Exception('test'); in a template.
2. Validate that after rendering such a template, exception stack is being saved to var/report in addition to its message being logged.

Questions or comments

1. Is passing Exception to LoggerInterface::critical a preferred way of logging issues? (I see it being used this way in other places)
2. Was saving non translated message in case of LocalizedException adding any value?

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] improve exception handling in Layout render #29606: improve exception handling in Layout render

[m2-assistant]

Hi @fsw. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi @engcom-Charlie. The fix is good to go. But we still need the to cover it at least with a unit test.
Thank you

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7994 has been created to process this Pull Request

[sidolov]

@magento create issue

[engcom-Alfa]

✔️ QA Passed

Add throw new \Exception('test exception'); in a template.

Before: ✖️ All exception messages are logged to system log

After: ✔️ Messages are logged to exception log file

[m2-assistant]

Hi @fsw, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.