Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Magento Integrity Dependency test in case to be used not in scope of app/code isntallation. #27578

Merged
merged 3 commits into from
Apr 25, 2020

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Apr 4, 2020

Description (*)

Provide possibility to run Dependency tests out of Magento repository.

  • Fix hard-dependency on word 'Magento' in the module name;
  • Fix hard-dependency on location of files under app/code folder to find the plugin.
    Also, adjust static tests framework tests.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Event: Global-Contribution-Day labels Apr 4, 2020
@rogyar rogyar self-assigned this Apr 4, 2020
@rogyar rogyar added Award: category of expertise Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: advanced labels Apr 8, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7279 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Echo engcom-Echo self-assigned this Apr 23, 2020
@slavvka slavvka added this to the 2.4.0 milestone Apr 23, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 25, 2020
@magento-engcom-team magento-engcom-team merged commit 66e0ac9 into magento:2.4-develop Apr 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2020

Hi @swnsma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: advanced Award: category of expertise Event: Global-Contribution-Day Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants