Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong customer group assign to order 26976 #27857

Merged
merged 29 commits into from
Sep 12, 2020
Merged

Fixed wrong customer group assign to order 26976 #27857

merged 29 commits into from
Sep 12, 2020

Conversation

ProkopovVitaliy
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Wrong Customer Group assign to order #26976: Issue title: Wrong Customer Group assign to order

Manual testing scenarios (*)

  1. In admin configuration Enable Automatic Assignment to Customer Group set yes
  2. login with different Customer Group then Default Group set in admin.
  3. Place order

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2020

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ProkopovVitaliy ProkopovVitaliy changed the title Fix 26976 Fixed wrong customer group assign to order 26976 Apr 14, 2020
@swnsma swnsma self-requested a review April 15, 2020 11:01
@swnsma swnsma self-assigned this Apr 15, 2020
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ProkopovVitaliy,

Could you check failed tests?
It seems that these tests related to changes introduced by your PR.

@engcom-Kilo engcom-Kilo self-assigned this May 25, 2020
@engcom-Kilo
Copy link
Contributor

Working with MFTF test

@engcom-Kilo
Copy link
Contributor

@ProkopovVitaliy Please resolve branch conflicts.
Thanks

@engcom-Kilo
Copy link
Contributor

@ProkopovVitaliy
Please grant permission to write for GIT branch ProkopovVitaliy:fix-26976

Thanks

ProkopovVitaliy and others added 2 commits May 28, 2020 11:19
# Conflicts:
#	app/code/Magento/Quote/Test/Unit/Observer/Frontend/Quote/Address/CollectTotalsObserverTest.php
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo
Copy link
Contributor

@magento run all tests

@lenaorobei
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-8039 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 19, 2020
@lenaorobei
Copy link
Contributor

@engcom-Kilo, could you please check failed tests.

@engcom-Kilo
Copy link
Contributor

@lenaorobei
Seems OK with tests.

@engcom-Hotel engcom-Hotel self-assigned this Aug 25, 2020
@engcom-Kilo engcom-Kilo removed their assignment Aug 25, 2020
@engcom-Alfa engcom-Alfa self-assigned this Aug 31, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. In admin configuration Enable Automatic Assignment to Customer Group (Go to Admin -> Stores -> Configuration -> Customers -> Customer Configuration -> Create New Account Options and set Enable Automatic Assignment to Customer Group to Yes);
  2. Login with different Customer Group then Default Group set in admin (test group for example);
  3. Place order;

Before: ✖️ order displays customer group which set as default group in admin configuration

2020-09-01_09-27

After: ✔️ order displays correct customer group

2020-09-01_09-34

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 1, 2020
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2020

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Checkout Component: Quote Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants