Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #27985 CMS page link active on current page #28004

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Fix #27985 CMS page link active on current page #28004

merged 2 commits into from
Jun 24, 2020

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Apr 27, 2020 •
edited
Loading

Description (*)

This PR helps to address issue #27985 , Added additional condition to check current page URL & link URL are equal.

Fixed Issues (if relevant)

  1. Privacy and Cookie Policy link not display as active on current page. #27985: Privacy and Cookie Policy link not display as active on current page

Manual testing scenarios (*)

  1. Click "privacy and cookie policy" link in footer -> After opening the page "privacy and cookie policy" should be active.
  2. Enter "baseurl/privacy-policy-cookie-restriction-mode/?test" -> After opening the page "privacy and cookie policy" should be active.
  3. vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist lib/internal/Magento/Framework/View/Test/Unit/Element/Html/Link/CurrentTest.php

Questions or comments

If any please let me know your feedbacks.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@srsathish92
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @srsathish92. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @srsathish92, here is your new Magento instance.
Admin access: https://pr-28004.instances.magento-community.engineering/admin_2107
Login: 5220cb9f Password: b3a2a07d57d1
Instance will be terminated in up to 3 hours.

@srsathish92 srsathish92 marked this pull request as draft April 28, 2020 04:12
@srsathish92 srsathish92 force-pushed the bug/27985-cms-page-link-active-issue branch from b0f38f4 to d5cc8cb Compare April 28, 2020 07:28
@srsathish92 srsathish92 marked this pull request as ready for review April 28, 2020 07:34
@dmytro-ch dmytro-ch self-assigned this Apr 28, 2020
@srsathish92 srsathish92 changed the title Fix#27985 CMS page link active on current page Fix #27985 CMS page link active on current page Apr 28, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

@dmytro-ch dmytro-ch closed this Apr 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dmytro-ch dmytro-ch reopened this Apr 28, 2020
@ghost ghost unassigned dmytro-ch Apr 28, 2020
@dmytro-ch dmytro-ch self-assigned this Apr 28, 2020
@ghost ghost added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 30, 2020
@sdzhepa sdzhepa linked an issue Apr 30, 2020 that may be closed by this pull request
Privacy and Cookie Policy link not display as active on current page. #27985
Closed
@sdzhepa sdzhepa added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Apr 30, 2020
VladimirZaets
VladimirZaets previously approved these changes May 4, 2020
View reviewed changes
@ghost ghost assigned VladimirZaets May 4, 2020
@ghost ghost added the Progress: accept label May 6, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 6, 2020
slavvka
slavvka requested changes May 12, 2020
View reviewed changes
Copy link
Member

@slavvka slavvka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srsathish92 please resolve conflicts and re-run tests after upgrade to PHP 7.4

@ghost ghost assigned slavvka May 12, 2020
@ghost ghost dismissed VladimirZaets’s stale review May 12, 2020 17:55

Pull Request state was updated. Re-review required.

@srsathish92
Copy link
Contributor Author

@slavvka I have fixed the conflicts, please review the same

@srsathish92 srsathish92 requested a review from slavvka May 21, 2020 18:32
@slavvka
Copy link
Member

slavvka commented May 22, 2020

@magento run all tests

@srsathish92
Copy link
Contributor Author

@magento run Database Compare

@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-7514 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Jun 24, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jun 24, 2020
@slavvka
ENGCOM-7514: Fix #27985 CMS page link active on current page #28004
aac7c4c
@magento-engcom-team magento-engcom-team merged commit a39e94a into magento:2.4-develop Jun 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka approved these changes

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@VladimirZaets VladimirZaets

@slavvka slavvka

@dmytro-ch dmytro-ch

@engcom-Delta engcom-Delta

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: View Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Privacy and Cookie Policy link not display as active on current page.
8 participants
@srsathish92 @magento-engcom-team @dmytro-ch @engcom-Delta @engcom-Kilo @slavvka @VladimirZaets @sdzhepa