Fix icon advance attributes properties not change

[mrtuvn]

Description (*)

Previously icon not change after user click on fieldset to expand content
Normal behavior icon will change to indicator user content expanded. Just like product form fieldset
After this patch icon changed correctly as expected

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Admin attributes Advanced Attribute Properties icon doesn't change while collapsing block #26022: Admin attributes Advanced Attribute Properties icon doesn't change while collapsing block
2. Fixes Toggle icon not working in create configuration Product creation Page #22702 Toggle icon not working in create configuration Product creation Page
   Summary grid in modal when configurable product create
   Recheck

Manual testing scenarios (*)

1. Magento 2.3.4+
2. Login admin > Store -> Attributes / Product -> Edit or create new any attribute -> Go tab properties -> Advanced attribute properties
3. Open tab advanced attribute properties

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[edenduong]

@magento give me test instance

[magento-engcom-team]

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-28032.instances.magento-community.engineering/admin_efab
Login: 6fe18699 Password: f7e4c09c0f7f
Instance will be terminated in up to 3 hours.

[edenduong]

@magento give me test instance

[magento-engcom-team]

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-28032.instances.magento-community.engineering/admin_5141
Login: d27f8fa2 Password: 3adca73269c9
Instance will be terminated in up to 3 hours.

[edenduong]

Hello @mrtuvn : Thank you for your contribution. This issue #22702 will occur again after your PRs. And I think the not active and active collapse can not have the same content icon "close". Could you please check it again and update your Pull Request ? Thank you !

[edenduong]

I think not active and active can not have the same content : "close". And this issue #22702 will occur again if you edit this line from "open" to "close"

[mrtuvn]

Hi @edenduong after see issue 22702 i just found another problem exist!. The class opened already hardcoded in html and seem not work properly as expected. If you click on title that class not change or removed
Here is reference
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProduct/view/adminhtml/web/template/variations/steps/summary-grid.html#L8

[mrtuvn]

If not active available content open will always used
See this
https://github.com/magento/magento2/blob/2.4-develop/app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/module/main/_collapsible-blocks.less#L75

[magento-engcom-team]

Hi @edenduong, thank you for the review.
ENGCOM-7505 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Login admin > Store -> Attributes / Product -> Edit or create new any attribute -> Go tab properties -> Advanced attribute properties
2. Open tab advanced attribute properties

Before:

After:

[m2-assistant]

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.