-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#: GraphQl. setShippingAddressesOnCart. Test coverage for The shipping address must contain either "customer_address_id" or "address".
error.
#28492
Conversation
Hi @atwixfirster. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
The shipping address must contain either "customer_address_id" or "address".
error.The shipping address must contain either "customer_address_id" or "address".
error.
@magento run all tests |
app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingAddressesOnCart.php
Outdated
Show resolved
Hide resolved
9e0f658
to
d5dd519
Compare
@magento run Static Tests |
@magento run Unit Tests, Database Compare, WebAPI Tests |
… for `The shipping address must contain either "customer_address_id" or "address".` error.
d5dd519
to
0d356ac
Compare
@magento run Static Tests |
@magento run Unit Tests, Database Compare, WebAPI Tests |
@magento run all tests |
Hi @dmytro-ch, thank you for the review. |
@magento run all tests |
@magento run unit tests |
@magento run all tests |
…Test coverage for `The shipping address must contain either "customer_address_id" or "address".` error. #28492
Hi @atwixfirster, thank you for your contribution! |
Description (*)
Provide a fix in the logic which allow to appear
The shipping address must contain either "customer_address_id" or "address".
error.Because now, if
input
.shipping_addresses
.customer_address_id
contains a NULL andinput
.shipping_addresses
.address
is not setthen \Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCart::execute creates an empty $shippingAddressInput['address'] and sets
which is not correct.
Also, PR adds the API-functional test to cover a mentioned error.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Thank you!