Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#28568:GraphQL query returns admin option value label… #28647

Merged
merged 6 commits into from
Jun 19, 2020
Merged

magento/magento2#28568:GraphQL query returns admin option value label… #28647

merged 6 commits into from
Jun 19, 2020

Conversation

gallyamov
Copy link
Contributor

Description (*)

This is for #28568 and #28572

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes GraphQL query returns admin option value label within aggregations #28568: Query returns admin option value label within aggregations
  2. Fixes [GraphQl] Custom attribute aggregations should return store specific option values #28572: Custom attribute aggregations should return store specific option values

Manual testing scenarios (*)

Check fixed issue for testing steps and expected results.

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @gallyamov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

danielrenaud
danielrenaud suggested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@danielrenaud danielrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gallyamov Can you please add api-functional test cases to cover this change

...de/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/AttributeOptionProvider.php Outdated Show resolved Hide resolved
...de/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/AttributeOptionProvider.php Show resolved Hide resolved
@ghost ghost assigned danielrenaud Jun 9, 2020
lbajsarowicz
lbajsarowicz suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store ID is optional, so you should add this after already defined parameters

...de/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/AttributeOptionProvider.php Show resolved Hide resolved
@ghost ghost assigned lbajsarowicz Jun 10, 2020
@gallyamov
Copy link
Contributor Author

@magento run all tests

@gallyamov
Copy link
Contributor Author

@magento run Functional Tests B2B

@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 11, 2020
@gallyamov
Copy link
Contributor Author

@magento run Functional Tests B2B

@danielrenaud
Copy link
Contributor

Review and QA passed

lbajsarowicz
lbajsarowicz approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7677 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@gallyamov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@gallyamov
Copy link
Contributor Author

@magento run all tests

@gallyamov
Copy link
Contributor Author

@magento run all tests

@gallyamov
Copy link
Contributor Author

@magento run Functional Tests B2B

@gallyamov
Copy link
Contributor Author

@magento run Functional Tests EE

@gallyamov gallyamov self-assigned this Jun 17, 2020
@ghost ghost unassigned gallyamov Jun 17, 2020
@ghost
Copy link

ghost commented Jun 17, 2020

@gallyamov unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

This was referenced Jun 19, 2020
Closed
Closed
magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2020
@cpartica
ENGCOM-7677: #28568:GraphQL query returns admin option value label… #…
c63c213 
…28647
@magento-engcom-team magento-engcom-team merged commit 7b71780 into magento:2.4-develop Jun 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2020

Hi @gallyamov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@danielrenaud danielrenaud danielrenaud approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@danielrenaud danielrenaud

Labels
Component: CatalogGraphQl PAP Partners acceleration program Progress: accept Project: GraphQL Release Line: 2.4
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
6 participants
@gallyamov @danielrenaud @magento-engcom-team @lbajsarowicz @nrkapoor @cpartica