Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

28628 price range wildcards #28745

Merged
merged 8 commits into from
Jun 27, 2020
Merged

28628 price range wildcards #28745

merged 8 commits into from
Jun 27, 2020

Conversation

gallyamov
Copy link
Contributor

Description (*)

This is for #28628

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes GraphQL price range numeric values #28628

Manual testing scenarios (*)

Check fixed issue for testing steps and expected results.

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 16, 2020

Hi @gallyamov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 16, 2020
@gallyamov
Copy link
Contributor Author

@magento run all tests

@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 16, 2020
@gallyamov
Copy link
Contributor Author

@magento run all tests

@danielrenaud
Copy link
Contributor

danielrenaud commented Jun 16, 2020 •
edited
Loading

@gallyamov please make sure api-functional tests are updated to reflect this change, and that this change is covered by api-functional tests for GraphQl perspective. There are already some tests that should be failing now with this change, so they should be updated with new behavior

danielrenaud
danielrenaud suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@danielrenaud danielrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to update api-functional tests and make all builds pass

app/code/Magento/Elasticsearch/SearchAdapter/Aggregation/Builder/Dynamic.php Outdated
unset($value['from'], $value['to']);

$rangeName = "{$from}_{$to}";
$rangeName = "{$value['from']}_{$value['to']}";
$resultData[$rangeName] = array_merge(['value' => $rangeName], $value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing static failure due to array_merge in loop. can it be refactored to avoid that?

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jun 16, 2020
@ghost ghost assigned danielrenaud Jun 16, 2020
@gallyamov
Copy link
Contributor Author

@magento run all tests

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Jun 17, 2020
@danielrenaud danielrenaud moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jun 17, 2020
@danielrenaud danielrenaud moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Jun 17, 2020
@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 27, 2020
@cpartica
ENGCOM-7707: 28628 price range wildcards #28745
3786d5a
@magento-engcom-team magento-engcom-team merged commit 6f647d1 into 2.4-develop Jun 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2020

Hi @gallyamov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 27, 2020
@okorshenko okorshenko deleted the 28628_price_range_wildcards branch August 25, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrenaud danielrenaud danielrenaud approved these changes

Assignees

@gallyamov gallyamov

@danielrenaud danielrenaud

Labels
Component: Catalog Component: CatalogSearch Component: Elasticsearch Component: Search PAP Partners acceleration program Progress: accept Project: GraphQL Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

GraphQL price range numeric values
5 participants
@gallyamov @danielrenaud @nrkapoor @cpartica @magento-engcom-team