Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL price range numeric values #28628

Closed
nrkapoor opened this issue Jun 9, 2020 · 2 comments · Fixed by #28745
Closed

GraphQL price range numeric values #28628

nrkapoor opened this issue Jun 9, 2020 · 2 comments · Fixed by #28745
Assignees
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL
Milestone

Comments

@nrkapoor
Copy link

nrkapoor commented Jun 9, 2020

In order to support a price range slider, price intervals returned in a product aggregation should be numeric only (no wildcards).

Current price aggregation response:

{
"options": [
{
"count": 1,
"label": "60-70",
"value": "60_70"
},
{
"count": 2,
"label": "90-",
"value": "90_
"
}
],
"attribute_code": "price",
"count": 5,
"label": "Price"
}
 

Expected price aggregation response:

{
"options": [
{
"count": 1,
"label": "60-70",
"value": "60_70"
},
{
"count": 2,
"label": "90-110",
"value": "90_110"
}
],
"attribute_code": "price",
"count": 5,
"label": "Price"
}
 

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @nrkapoor. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for QA in Community Backlog Jun 9, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 9, 2020
@nrkapoor nrkapoor moved this from Ready for QA to Good First Issue in Community Backlog Jun 9, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 10, 2020

Hi @gallyamov. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost moved this from Good First Issue to Dev in Progress in Community Backlog Jun 10, 2020
gallyamov added a commit that referenced this issue Jun 11, 2020
- Removed wildcard usage for price filters
gallyamov added a commit to gallyamov/magento2 that referenced this issue Jun 16, 2020
- Fixed price range wildcard values and associated test cases
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jun 16, 2020
gallyamov added a commit that referenced this issue Jun 16, 2020
gallyamov added a commit that referenced this issue Jun 16, 2020
gallyamov added a commit that referenced this issue Jun 17, 2020
@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

Successfully merging a pull request may close this issue.

4 participants