-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Rest-API updating product stock_item deletes downloadable product data #28799
fix Rest-API updating product stock_item deletes downloadable product data #28799
Conversation
Hi @engcom-Charlie. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @engcom-Charlie
Thanks for your contribution
Please add to all changed files
declare(strict_types=1);
You can read more here
I would also ask you to add type declaration everywhere in files you changed and replace object declaration with a more precise type.
@magento run all tests |
@magento run all tests |
Hi @Stepa4man, thank you for the review.
|
✔️ QA passed
❌ Before:
✔️ After:
|
…dable product data #28799
Hi @engcom-Charlie, thank you for your contribution! |
Description (*)
Fixed and covered by test
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
See #21811
Questions or comments
Contribution checklist (*)