Remove related products that not exist in map list.

[forfin]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Disable product that relate to another product make graphql break when query. #28892

Manual testing scenarios (*)

1. Create first product (name: test-01).
2. Create another product (name: test-02). + Add test-01 as related products
3. Disable product test-01
4. Send graphql request to get relate product

query productDetail {
  productDetail: products(pageSize: 10, currentPage: 1, search: "") {
    items {
      id
      sku
      name
      related_products {
        id
        sku
        url_key
      }
    }
  }
}

5. It return result with no error

{
    "data": {
        "productDetail": {
            "items": [
                {
                    "id": 2,
                    "sku": "Test-02",
                    "name": "Test-02",
                    "related_products": []
                }
            ]
        }
    }
}

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @forfin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[gabrieldagama]

Hi @forfin thanks for the pull request, it looks great! All our contributions now have to be covered with tests, I believe we could cover this change with integration tests, let me know if you are available to cover this.

Thank you!

[gabrieldagama]

Adding this to change state, it needs to be covered with tests.

[engcom-Echo]

I will take care of test coverage.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

Seems failed functional tests not related to the changes in this PR

[engcom-Echo]

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8172 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

@forfin thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Delta]

✔️ QA passed
Was checked according Manual testing scenarios
Result:
❌ Before:

✔️ After:

[engcom-Delta]

Note: Automation tests are passed

[m2-assistant]

Hi @forfin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.