Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for communication.xml Handlers merging processs #28926

Merged
merged 13 commits into from
Dec 10, 2020
Merged

Fix for communication.xml Handlers merging processs #28926

merged 13 commits into from
Dec 10, 2020

Conversation

matiashidalgo
Copy link
Contributor

@matiashidalgo matiashidalgo commented Jun 29, 2020 •
edited by engcom-Charlie
Loading

Description (*)

This changes fixes the "handler" merging process into communication.xml files which currently overrides all the handlers with the last one created, ignoring it's different names as expected. Issue found during custom handler development for MCOM module where there was already a handler for a message.

Manual testing scenarios (*)

  1. Please see Fix for communication.xml Handlers merging processs #28926 (comment)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix for communication.xml Handlers merging processs #29528: Fix for communication.xml Handlers merging processs

@m2-assistant
Copy link

m2-assistant bot commented Jun 29, 2020

Hi @matiashidalgo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 29, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 13, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 13, 2020
Closed
4 tasks
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 13, 2020
lenaorobei
lenaorobei requested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

Could you please add integration test to cover this?

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 18, 2020
@ghost ghost assigned lenaorobei Aug 18, 2020
@lenaorobei
Copy link
Contributor

@magento run all tests

@matiashidalgo
Copy link
Contributor Author

Thanks for fixing it.

Could you please add integration test to cover this?

Hi @lenaorobei since this is a fix to Framework I can not find any example of an Integration test, would you mind to point me out to an example of this and tell me which module I'm supposed to use for place my integration test?

@lenaorobei
Copy link
Contributor

Sure! Please see example dev/tests/integration/testsuite/Magento/Framework/Communication/ConfigTest.php.

I also noticed that Static Tests build failed. Here is the report https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/28926/f2b73dfd3095f563cfde67e1f874d8e1/Statics/allure-report-b2b/index.html#suites/51d3ab4d5d77a0bc6a7ea344e9e7e6be/dccf717ef048c46e/

Looks like this particular case needs to be suppressed, because default parameters are different.

@lenaorobei
Copy link
Contributor

@magento run all tests

@matiashidalgo
Copy link
Contributor Author

Sure! Please see example dev/tests/integration/testsuite/Magento/Framework/Communication/ConfigTest.php.

I also noticed that Static Tests build failed. Here is the report https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/28926/f2b73dfd3095f563cfde67e1f874d8e1/Statics/allure-report-b2b/index.html#suites/51d3ab4d5d77a0bc6a7ea344e9e7e6be/dccf717ef048c46e/

Looks like this particular case needs to be suppressed, because default parameters are different.

Thank you a lot for pointing me to the right place, I've found the reason which makes the integration test not detect this issues so now it is covered.

About the static code error, I didn't found how to fix it, can you help me once again and point me out where this can be fixed?

@lbajsarowicz
Copy link
Contributor

@magento run all tests

@matiashidalgo
Copy link
Contributor Author

@magento run all tests

@lbajsarowicz
Copy link
Contributor

@matiashidalgo Perfect timing! I was just sending the recommendations to you.

@gabrieldagama
Copy link
Contributor

@magento run Functional Tests CE, WebAPI Tests

@matiashidalgo
Copy link
Contributor Author

@magento run Functional Tests CE

@matiashidalgo
Copy link
Contributor Author

@engcom-Charlie @gabrieldagama all checks passed now.

Please do let me know if something else is needed from me.

gabrieldagama
gabrieldagama approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matiashidalgo, thanks for your contribution, the changes look good to me!

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Nov 18, 2020
@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8232 has been created to process this Pull Request

@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Nov 18, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked case from Manual testing scenarios
❌ Before:
#28926Main

✔️ After:
#28926PR

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Nov 18, 2020
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Nov 18, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Nov 18, 2020
@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@engcom-Delta engcom-Delta moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Nov 18, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 10, 2020
@gabrieldagama
ENGCOM-8232: Fix for communication.xml Handlers merging processs #28926
c63d88c
@magento-engcom-team magento-engcom-team merged commit 95e4fef into magento:2.4-develop Dec 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @matiashidalgo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama approved these changes

@engcom-Delta engcom-Delta Awaiting requested review from engcom-Delta

@lbajsarowicz lbajsarowicz Awaiting requested review from lbajsarowicz

@lenaorobei lenaorobei Awaiting requested review from lenaorobei

Assignees

@lbajsarowicz lbajsarowicz

@gabrieldagama gabrieldagama

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Communication Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix for communication.xml Handlers merging processs
9 participants
@matiashidalgo @sidolov @lenaorobei @lbajsarowicz @engcom-Foxtrot @magento-engcom-team @engcom-Delta @engcom-Charlie @gabrieldagama