Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for communication.xml Handlers merging processs #28926

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/etc/di.xml
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,17 @@
</arguments>
</type>
<preference for="Magento\AsynchronousOperations\Model\ConfigInterface" type="Magento\WebapiAsync\Model\Config\Proxy" />
<virtualType name="Magento\Framework\Communication\Config\Reader\XmlReader" type="Magento\Framework\Config\Reader\Filesystem">
<arguments>
<argument name="converter" xsi:type="object">Magento\Framework\Communication\Config\Reader\XmlReader\Converter</argument>
<argument name="schemaLocator" xsi:type="object">Magento\Framework\Communication\Config\Reader\XmlReader\SchemaLocator</argument>
<argument name="fileName" xsi:type="string">communication.xml</argument>
<argument name="idAttributes" xsi:type="array">
<item name="/config/topic" xsi:type="string">name</item>
<item name="/config/topic/handler" xsi:type="string">name</item>
</argument>
</arguments>
</virtualType>
<type name="Magento\Framework\Communication\Config\CompositeReader">
<arguments>
<argument name="readers" xsi:type="array">
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
'type' => \Magento\Customer\Api\CustomerRepositoryInterface::class,
'method' => 'delete',
],
'customerCreatedExtra' => [
'type' => \Magento\Customer\Api\CustomerRepositoryInterface::class,
'method' => 'save',
],
'saveNameNotDisabled' => [
'type' => \Magento\Customer\Api\CustomerRepositoryInterface::class,
'method' => 'save',
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Communication/etc/communication.xsd">
<topic name="customerAdded" request="string[]">
<handler name="customerCreatedExtra" type="Magento\Customer\Api\CustomerRepositoryInterface" method="save"/>
</topic>
</config>
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
'type' => \Magento\Customer\Api\CustomerRepositoryInterface::class,
'method' => 'delete',
],
'customerCreatedExtra' => [
'type' => \Magento\Customer\Api\CustomerRepositoryInterface::class,
'method' => 'save',
],
'saveNameNotDisabled' => [
'type' => \Magento\Customer\Api\CustomerRepositoryInterface::class,
'method' => 'save',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ lib/internal/Magento/Framework/Interception/Test/Unit/Code/Generator/Interceptor
lib/internal/Magento/Framework/Interception/Test/Unit/Config/ConfigTest.php
dev/tests/integration/framework/deployTestModules.php
dev/tests/integration/testsuite/Magento/Framework/Code/Generator/AutoloaderTest.php
dev/tests/integration/testsuite/Magento/Framework/Communication/ConfigTest.php
dev/tests/integration/testsuite/Magento/Framework/Filter/DirectiveProcessor/SimpleDirectiveTest.php
dev/tests/integration/testsuite/Magento/Framework/Session/ConfigTest.php
dev/tests/integration/testsuite/Magento/Framework/Session/SessionManagerTest.php
Expand Down

This file was deleted.