-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2-page-builder#543: Content Product Attributes Default… #29238
magento/magento2-page-builder#543: Content Product Attributes Default… #29238
Conversation
… Sorting Order - Reordering Description/Short Description Product Attributes
Hi @bluemwhitew. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@bluemwhitew unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
'short_description', | ||
100 | ||
'description', | ||
110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch will work only for installation. You need to write a new patch.
… Sorting Order - Partially Reverting 53b25c7
… Sorting Order - Adding New Patch
… Sorting Order - Refactoring
app/code/Magento/Catalog/Setup/Patch/Data/UpdateProductDescriptionOrder.php
Outdated
Show resolved
Hide resolved
… Sorting Order - Code Review Feedback/Amends
… Sorting Order - Refactoring
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix failed tests
… Sorting Order - Fixing Static Tests
… Sorting Order - Fixing Unit Tests
… Sorting Order - Fixing Functional Tests
Hi @VladimirZaets, thank you for the review.
|
@magento run Semantic Version Checker |
Hi @bluemwhitew, thank you for your contribution! |
Description (*)
Reordered the
description
andshort_description
product attributes to better accommodate planned Page Builder content staging changes.Fixed Issues
Builds
N/A
Related Pull Requests
magento/magento2-page-builder#585
Questions or Comments
N/A
Checklist
Test Plan
Manual Testing Scenarios
php bin/magento setup:upgrade
description
andshort_description
respectivelyAutomated MFTF Tests
-- Scenarios are not high enough priority
Manual Hip Tests
-- Scenarios are not high enough priority