Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2-page-builder#543: Content Product Attributes Default… #29238

Conversation

bluemwhitew
Copy link
Contributor

@bluemwhitew bluemwhitew commented Jul 22, 2020

Description (*)

Reordered the description and short_description product attributes to better accommodate planned Page Builder content staging changes.

Fixed Issues

  1. Fixes Content product attributes default sorting order magento2-page-builder#543

Builds

N/A

Related Pull Requests

magento/magento2-page-builder#585

Questions or Comments

N/A

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Test Plan

Manual Testing Scenarios

  • New Magento Installation
  1. Create a new Product (Catalog » Products » Add Product)
  2. Expand the Content accordion
  3. Verify that Short Description appears before Description
  • Existing Magento Installation:
  1. Create a new Product (Catalog » Products » Add Product)
  2. Expand the Content accordion
  3. Verify that Description appears before Short Description
  4. Update to include this changeset
  5. Run php bin/magento setup:upgrade
  6. Create a new Product (Catalog » Products » Add Product)
  7. Expand the Content accordion
  8. Verify that Short Description appears before Description
  • Attribute Sorting in Admin:
  1. Modify Attribute Sets (Stores » Attributes » Attribute Set)
  2. Click on the "Default" Attribute Set
  3. Switch the order of description and short_description respectively
  4. Click Save
  5. Create a new Product (Catalog » Products » Add Product)
  6. Expand the Content accordion
  7. Verify that Description appears before Short Description

Automated MFTF Tests

  • No new tests needed
    -- Scenarios are not high enough priority
  • Update existing tests to pass

Manual Hip Tests

  • No new tests needed. No updated tests needed
    -- Scenarios are not high enough priority

… Sorting Order

- Reordering Description/Short Description Product Attributes
@m2-assistant
Copy link

m2-assistant bot commented Jul 22, 2020

Hi @bluemwhitew. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost
Copy link

ghost commented Jul 22, 2020

@bluemwhitew unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

'short_description',
100
'description',
110
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch will work only for installation. You need to write a new patch.

@ghost ghost assigned omiroshnichenko Jul 22, 2020
@bluemwhitew bluemwhitew added the Partner: Vaimo Pull Request is created by partner Vaimo label Jul 22, 2020
@bluemwhitew
Copy link
Contributor Author

@magento run all tests

Copy link
Contributor

@omiroshnichenko omiroshnichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix failed tests

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Jul 23, 2020
@ghost ghost added the Progress: review label Jul 24, 2020
@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Jul 24, 2020
@omiroshnichenko omiroshnichenko moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Jul 28, 2020
@ghost ghost moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard Jul 29, 2020
@ghost ghost assigned VladimirZaets Jul 29, 2020
@VladimirZaets VladimirZaets moved this from Ready for Testing to Merge in Progress in Pull Requests Dashboard Jul 29, 2020
@ghost ghost moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Jul 29, 2020
@VladimirZaets VladimirZaets moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 29, 2020
@VladimirZaets VladimirZaets moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Jul 29, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7918 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dhaecker
Copy link
Contributor

dhaecker commented Aug 6, 2020

@magento run Semantic Version Checker

@magento-engcom-team magento-engcom-team merged commit 634bc2c into magento:2.4-develop Aug 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @bluemwhitew, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 6, 2020
@bluemwhitew bluemwhitew deleted the 543_product-attributes-default-sorting-order branch August 6, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Content product attributes default sorting order
5 participants