-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2-page-builder#543: Content Product Attributes Default… #29238
Merged
magento-engcom-team
merged 11 commits into
magento:2.4-develop
from
bluemwhitew:543_product-attributes-default-sorting-order
Aug 6, 2020
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
53b25c7
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew 00650a8
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew eb09069
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew 67851de
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew 374e86f
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew 6e8867f
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew 8b5cb3d
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew b74061c
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew 1bd733a
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew 2357344
magento/magento2-page-builder#543: Content Product Attributes Default…
bluemwhitew c695c99
Merge branch '2.4-develop' into 543_product-attributes-default-sortin…
bluemwhitew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
app/code/Magento/Catalog/Setup/Patch/Data/UpdateProductDescriptionOrder.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
<?php | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
|
||
namespace Magento\Catalog\Setup\Patch\Data; | ||
|
||
use Magento\Catalog\Setup\CategorySetup; | ||
use Magento\Catalog\Setup\CategorySetupFactory; | ||
use Magento\Framework\Setup\ModuleDataSetupInterface; | ||
use Magento\Framework\Setup\Patch\DataPatchInterface; | ||
|
||
/** | ||
* Class UpdateProductDescriptionOrder | ||
* | ||
* @package Magento\Catalog\Setup\Patch | ||
*/ | ||
class UpdateProductDescriptionOrder implements DataPatchInterface | ||
{ | ||
/** | ||
* @var ModuleDataSetupInterface | ||
*/ | ||
private $moduleDataSetup; | ||
|
||
/** | ||
* @var CategorySetupFactory | ||
*/ | ||
private $categorySetupFactory; | ||
|
||
/** | ||
* @param ModuleDataSetupInterface $moduleDataSetup | ||
* @param CategorySetupFactory $categorySetupFactory | ||
*/ | ||
public function __construct( | ||
ModuleDataSetupInterface $moduleDataSetup, | ||
CategorySetupFactory $categorySetupFactory | ||
) { | ||
$this->moduleDataSetup = $moduleDataSetup; | ||
$this->categorySetupFactory = $categorySetupFactory; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function apply() | ||
{ | ||
/** @var CategorySetup $categorySetup */ | ||
$categorySetup = $this->categorySetupFactory->create(['setup' => $this->moduleDataSetup]); | ||
$attributeSetId = $categorySetup->getDefaultAttributeSetId(\Magento\Catalog\Model\Product::ENTITY); | ||
|
||
// Content | ||
$categorySetup->addAttributeGroup( | ||
\Magento\Catalog\Model\Product::ENTITY, | ||
$attributeSetId, | ||
'Content', | ||
15 | ||
); | ||
$categorySetup->updateAttributeGroup( | ||
\Magento\Catalog\Model\Product::ENTITY, | ||
$attributeSetId, | ||
'Content', | ||
'tab_group_code', | ||
'basic' | ||
); | ||
$categorySetup->addAttributeToGroup( | ||
\Magento\Catalog\Model\Product::ENTITY, | ||
$attributeSetId, | ||
'Content', | ||
'short_description', | ||
100 | ||
); | ||
$categorySetup->addAttributeToGroup( | ||
\Magento\Catalog\Model\Product::ENTITY, | ||
$attributeSetId, | ||
'Content', | ||
'description', | ||
110 | ||
); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public static function getDependencies() | ||
{ | ||
return [ | ||
UpdateMediaAttributesBackendTypes::class, | ||
]; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public static function getVersion() | ||
bluemwhitew marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
return '2.3.5'; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getAliases() | ||
{ | ||
return []; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omiroshnichenko @bluemwhitew do we need to add new integration tests for these new php functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no