Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Added some ActionGroups to Analytics module #29634

Merged
merged 5 commits into from
Sep 2, 2020
Merged

[MFTF] Added some ActionGroups to Analytics module #29634

merged 5 commits into from
Sep 2, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Aug 18, 2020 •
edited by m2-assistant bot
Loading

This PR adds AdminConfigGeneralAnalyticsPageOpenActionGroup and AssertAdminAdvancedReportingPageUrlActionGroup ActionGroups to Analytics module

Resolved issues:

  1. resolves [Issue] [MFTF] Added some ActionGroups to Analytics module #29648: [MFTF] Added some ActionGroups to Analytics module

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Aug 18, 2020
@magento-engcom-team magento-engcom-team added Component: Analytics Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 18, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@rogyar rogyar self-assigned this Aug 18, 2020
rogyar
rogyar reviewed Aug 18, 2020
View reviewed changes
...e/Magento/Analytics/Test/Mftf/ActionGroup/AdminConfigGeneralAnalyticsPageOpenActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminConfigGeneralAnalyticsPageOpenActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend include a verb into the name that describes an action in the action group. It's a common practice and we will have more or less transparent naming convent in this case.

AdminOpenConfigGeneralAnalytticsPageActionGroup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 18, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 18, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 18, 2020
Closed
VladimirZaets
VladimirZaets requested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203. Please take a look at builds that are failed and rename action group according to the recommendation provided by @rogyar.

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 18, 2020
@ghost ghost assigned VladimirZaets Aug 18, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Aug 23, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8061 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 27, 2020
@rogyar
Copy link
Contributor

rogyar commented Aug 27, 2020

Hi @sidolov. Could you approve this one, please?
Thank you!

@ghost ghost assigned sidolov Aug 27, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 27, 2020

@magento run all tests

@sidolov sidolov moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Aug 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8061 has been created to process this Pull Request

@engcom-Charlie engcom-Charlie self-assigned this Aug 28, 2020
@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 28, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 28, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 2, 2020
@sidolov
ENGCOM-8061: [MFTF] Added some ActionGroups to Analytics module #29634
badf28b
@magento-engcom-team magento-engcom-team merged commit b0ee936 into magento:2.4-develop Sep 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets requested changes

@rogyar rogyar rogyar approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@rogyar rogyar

@VladimirZaets VladimirZaets

@sidolov sidolov

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Analytics Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Added some ActionGroups to Analytics module
6 participants
@Usik2203 @sidolov @magento-engcom-team @rogyar @VladimirZaets @engcom-Charlie