Add Regions for Uruguay. #29722

barbanet · 2020-08-23T23:00:11Z

Description (*)

Regions for Uruguay will be added with this PR. Regions are using the ISO 3166-2 code (the regions table can be check here https://en.wikipedia.org/wiki/ISO_3166-2:UY)

Manual testing scenarios (*)

Once you finish the installation the country should show you Regions on shipping estimation, checkout or when you edit the customer address form.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Add Regions for Uruguay. #29729: Add Regions for Uruguay.

m2-assistant · 2020-08-23T23:00:14Z

Hi @barbanet. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

BarnyShergold · 2020-08-23T23:11:30Z

@magento run all tests

BarnyShergold

Ensure all tests are passing as well as requested changes

app/code/Magento/Directory/Setup/Patch/Data/AddDataForUruguay.php

sidolov · 2020-08-24T15:29:16Z

@magento create issue

barbanet · 2020-08-25T04:46:27Z

Thank you @BarnyShergold for all those recommendations. I'll take care ASAP.

engcom-Echo · 2020-09-03T11:04:16Z

Hi, @barbanet. Could you please check failed tests and recommendations?

Thank you.

engcom-Echo · 2020-09-07T09:34:32Z

@magento run all tests

engcom-Echo · 2020-09-07T12:23:22Z

Hi @barbanet. Can you fix "Static Tests"?
Failed functional tests not related to the changes in this PR

gabrieldagama · 2020-09-07T12:40:32Z

The risk was set tolow due to: the suggested changes shouldn't impact other areas.

engcom-Echo · 2020-09-11T13:26:24Z

@magento run all tests

engcom-Bravo

Hello @BarnyShergold

Can you please add an appropriate label for test coverage?

Thank you

Pull Request state was updated. Re-review required.

magento-engcom-team · 2020-09-24T12:40:43Z

Hi @BarnyShergold, thank you for the review.
ENGCOM-8244 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo · 2020-09-25T09:41:04Z

✔️ QA Passed

Regions are added for Uruguay country

See the result BEFORE switching to the PR

and AFTER switching to the PR

List of regions

Storefront

✔️ Successfully submitted order and created shipment to Uruguay

m2-assistant · 2020-09-30T02:12:20Z

Hi @barbanet, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Add Regions for Uruguay.

b7cec7d

ghost added this to Pending Review in Pull Requests Dashboard Aug 23, 2020

ghost added the Progress: pending review label Aug 23, 2020

magento-engcom-team added Component: Directory Release Line: 2.4 Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner labels Aug 23, 2020

BarnyShergold self-assigned this Aug 23, 2020

BarnyShergold requested changes Aug 24, 2020

View reviewed changes

ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 24, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 24, 2020

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 24, 2020

m2-assistant bot mentioned this pull request Aug 24, 2020

[Issue] Add Regions for Uruguay. #29729

Closed

VladimirZaets self-assigned this Aug 26, 2020

engcom-Echo self-assigned this Sep 3, 2020

Fixed code style. Changed DataInstallerFactory FQDN by Import.

37675cc

gabrieldagama added the Risk: low label Sep 7, 2020

fix static

c62d33a

engcom-Echo requested a review from BarnyShergold September 14, 2020 06:47

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 23, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 23, 2020

engcom-Bravo requested changes Sep 23, 2020

View reviewed changes

ghost moved this from Testing in Progress to Changes Requested in Pull Requests Dashboard Sep 23, 2020

ghost added Progress: needs update and removed Progress: testing in progress labels Sep 23, 2020

engcom-Echo requested a review from BarnyShergold September 24, 2020 07:05

BarnyShergold approved these changes Sep 24, 2020

View reviewed changes

ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Sep 24, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Sep 24, 2020

BarnyShergold added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 24, 2020

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 25, 2020

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 25, 2020

ghost removed the Progress: ready for testing label Sep 25, 2020

engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 25, 2020

ghost added Progress: testing in progress Progress: extended testing and removed Progress: testing in progress labels Sep 25, 2020

engcom-Bravo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 25, 2020

ghost added Progress: accept and removed Progress: extended testing labels Sep 25, 2020

magento-engcom-team pushed a commit that referenced this pull request Sep 30, 2020

ENGCOM-8244: Add Regions for Uruguay. #29722

fa95e33

magento-engcom-team merged commit 7a48783 into magento:2.4-develop Sep 30, 2020

ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Regions for Uruguay. #29722

Add Regions for Uruguay. #29722

barbanet commented Aug 23, 2020 •

edited by engcom-Bravo

Loading

m2-assistant bot commented Aug 23, 2020

BarnyShergold commented Aug 23, 2020

BarnyShergold left a comment

sidolov commented Aug 24, 2020

barbanet commented Aug 25, 2020

engcom-Echo commented Sep 3, 2020

engcom-Echo commented Sep 7, 2020

engcom-Echo commented Sep 7, 2020

gabrieldagama commented Sep 7, 2020

engcom-Echo commented Sep 11, 2020

engcom-Bravo left a comment

magento-engcom-team commented Sep 24, 2020

engcom-Bravo commented Sep 25, 2020

m2-assistant bot commented Sep 30, 2020

Add Regions for Uruguay. #29722

Add Regions for Uruguay. #29722

Conversation

barbanet commented Aug 23, 2020 • edited by engcom-Bravo Loading

Description (*)

Manual testing scenarios (*)

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Aug 23, 2020

BarnyShergold commented Aug 23, 2020

BarnyShergold left a comment

Choose a reason for hiding this comment

sidolov commented Aug 24, 2020

barbanet commented Aug 25, 2020

engcom-Echo commented Sep 3, 2020

engcom-Echo commented Sep 7, 2020

engcom-Echo commented Sep 7, 2020

gabrieldagama commented Sep 7, 2020

engcom-Echo commented Sep 11, 2020

engcom-Bravo left a comment

Choose a reason for hiding this comment

magento-engcom-team commented Sep 24, 2020

engcom-Bravo commented Sep 25, 2020

m2-assistant bot commented Sep 30, 2020

barbanet commented Aug 23, 2020 •

edited by engcom-Bravo

Loading