Categories permissions for "categories" and "categoryList" #29883

pmarjan · 2020-09-03T11:44:35Z

Description (*)

Fixes #29880

Collection Processors (via Composite processor) are added. Context is passed as optional parameter.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/319

Fixed Issues (if relevant)

GraphQL "categories" and "categoryList" do not consider Category Permissions configuration

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…tegory Permissions configuration Introduce collection processors, pass the context so to obtain customer group

m2-assistant · 2020-09-03T11:44:38Z

Hi @pmarjan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

pmarjan · 2020-09-03T12:51:24Z

@magento run all tests

BarnyShergold

There seems to be quite a lot of new code files here and some substantial changes to core methods - is there a reason why there is no test coverage?

BarnyShergold · 2020-09-07T15:31:05Z

...hQl/Model/Resolver/Categories/DataProvider/Category/CollectionProcessor/CatalogProcessor.php

+    /** @var SearchCriteriaCollectionProcessor */
+    private $collectionProcessor;
+
+    public function __construct(


No DocBlock

BarnyShergold · 2020-09-07T15:34:13Z

...hQl/Model/Resolver/Categories/DataProvider/Category/CollectionProcessor/CatalogProcessor.php

+        SearchCriteriaInterface $searchCriteria,
+        ContextInterface $context = null
+    ): Collection
+    {


This { should be on previous line

hey @BarnyShergold

the changes to core methods are with the purpose to expose modular collection processing, so other layers in the application can have a say what the collection consists of.
Check maybe implementation of "products" query for an example - it is the same idea.

On a closer look, please notice, there is no bug to be solved, or new requirement to be satisfied, just a refactor, thus, should be sufficient that already present api-functinal tests do not break (and they don't :) ), no need for new ones.

In more details, I would bring your attention to GraphQl/Catalog tests, and there all the Category*.Test.php and all tests from CategoriesQuery folder are the top relevant to verify the refactor.

Anyway, bigger picture is here: #28550, if it helps to gain depth on the idea that is running in this PR. If any questions, just contact me... I can give you even more details.

@pmarjan - Your reasoning is sound - just wanted to check!
You just need to fix the minor format issues and the failing tests and all will be good.

…tegory Permissions configuration Address static tests

pmarjan · 2020-09-11T08:51:26Z

@magento run all tests

pmarjan · 2020-09-15T12:37:56Z

@magento run all tests

pmarjan · 2020-09-25T11:01:31Z

@magento run all tests

pmarjan · 2020-09-25T11:24:19Z

@magento run all tests

BarnyShergold · 2020-09-28T23:43:49Z

@magento run all tests

cpartica · 2020-09-29T02:18:27Z

...alogGraphQl/Model/Resolver/Categories/DataProvider/Category/CollectionProcessorInterface.php

+    public function process(
+        Collection $collection,
+        SearchCriteriaInterface $searchCriteria,
+        ContextInterface $context = null


just a minor observation in comparison to the product processor
Noticed that there we passed attributes as well. I guess here we did not need it here. Not sure because this is meant as an extension point if we need to add it and just not use it ourselves..maybe other extensions will..

Good point. Now, I have edited to pass attributesNames as well. Currently are not used, but someday maybe someone extends this.

…tegory Permissions configuration PR review points

m2-assistant · 2020-10-10T20:15:17Z

Hi @pmarjan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#29880: GraphQL categories and categoryList do not consider Ca…

a6c98da

…tegory Permissions configuration Introduce collection processors, pass the context so to obtain customer group

pmarjan added Project: GraphQL PAP Partners acceleration program labels Sep 3, 2020

pmarjan added this to the 2.4.2 milestone Sep 3, 2020

pmarjan requested a review from cpartica September 3, 2020 11:44

pmarjan self-assigned this Sep 3, 2020

ghost added this to Pending Review in Pull Requests Dashboard Sep 3, 2020

ghost added the Progress: pending review label Sep 3, 2020

magento-engcom-team added Component: CatalogGraphQl Release Line: 2.4 labels Sep 3, 2020

ghost unassigned pmarjan Sep 3, 2020

magento-engcom-team added Partner: Comwrap partners-contribution Pull Request is created by Magento Partner labels Sep 3, 2020

pmarjan self-assigned this Sep 3, 2020

pmarjan linked an issue Sep 3, 2020 that may be closed by this pull request

GraphQL "categories" and "categoryList" do not consider Category Permissions configuration #29880

Closed

5 tasks

pmarjan mentioned this pull request Sep 3, 2020

GraphQL "categories" and "categoryList" do not consider Category Permissions configuration #29880

Closed

5 tasks

nrkapoor mentioned this pull request Sep 3, 2020

B2B shared catalog feature set #28550

Closed

BarnyShergold requested changes Sep 7, 2020

View reviewed changes

ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Sep 7, 2020

ghost assigned BarnyShergold Sep 7, 2020

ghost added Progress: needs update and removed Progress: pending review labels Sep 7, 2020

magento#29880: GraphQL categories and categoryList do not consider Ca…

ef20485

…tegory Permissions configuration Address static tests

nrkapoor requested review from dthampy, cspruiell and prabhuram93 September 19, 2020 14:30

nrkapoor requested a review from melnikovi September 19, 2020 14:30

cpartica requested changes Sep 29, 2020

View reviewed changes

ghost assigned cpartica Sep 29, 2020

magento#29880: GraphQL categories and categoryList do not consider Ca…

c55bcce

…tegory Permissions configuration PR review points

cpartica approved these changes Oct 7, 2020

View reviewed changes

ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Oct 7, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Oct 7, 2020

cpartica approved these changes Oct 7, 2020

View reviewed changes

magento-engcom-team merged commit b279b6d into magento:2.4-develop Oct 10, 2020

sidolov removed this from Ready for Testing in Pull Requests Dashboard Oct 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Categories permissions for "categories" and "categoryList" #29883

Categories permissions for "categories" and "categoryList" #29883

pmarjan commented Sep 3, 2020 •

edited

Loading

m2-assistant bot commented Sep 3, 2020

pmarjan commented Sep 3, 2020

BarnyShergold left a comment

BarnyShergold Sep 7, 2020

pmarjan Sep 29, 2020

BarnyShergold Sep 7, 2020

pmarjan Sep 8, 2020

BarnyShergold Sep 24, 2020

pmarjan commented Sep 11, 2020

pmarjan commented Sep 15, 2020

pmarjan commented Sep 25, 2020

pmarjan commented Sep 25, 2020

BarnyShergold commented Sep 28, 2020

cpartica Sep 29, 2020

pmarjan Sep 29, 2020

m2-assistant bot commented Oct 10, 2020

Categories permissions for "categories" and "categoryList" #29883

Categories permissions for "categories" and "categoryList" #29883

Conversation

pmarjan commented Sep 3, 2020 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Sep 3, 2020

pmarjan commented Sep 3, 2020

BarnyShergold left a comment

Choose a reason for hiding this comment

BarnyShergold Sep 7, 2020

Choose a reason for hiding this comment

pmarjan Sep 29, 2020

Choose a reason for hiding this comment

BarnyShergold Sep 7, 2020

Choose a reason for hiding this comment

pmarjan Sep 8, 2020

Choose a reason for hiding this comment

BarnyShergold Sep 24, 2020

Choose a reason for hiding this comment

pmarjan commented Sep 11, 2020

pmarjan commented Sep 15, 2020

pmarjan commented Sep 25, 2020

pmarjan commented Sep 25, 2020

BarnyShergold commented Sep 28, 2020

cpartica Sep 29, 2020

Choose a reason for hiding this comment

pmarjan Sep 29, 2020

Choose a reason for hiding this comment

m2-assistant bot commented Oct 10, 2020

pmarjan commented Sep 3, 2020 •

edited

Loading