B2B shared catalog feature set

[nrkapoor]

As a Magento Developer,

I want to expose B2B shared catalog functionality via GraphQL

So that customers can use a more flexible and performant API technology.

Connected tickets

• GraphQL "categories" and "categoryList" do not consider Category Permissions configuration
• Prices should be hidden from products query results when the category permissions chooses to hide them
• Search should be disabled from products query when general configuration chooses to disabled it
• "Add to Cart" mutations in GraphQl should consider Catalog Permissions

Acceptance Criteria

GraphQL respects user permissions for all storefront operations.
WebAPI test coverage and indirectly covered by its sub-tickets

• Sub tickets should provide WebApi coverage on EE level - coming from the CatalogPermissions feature
• Specifically this ticket should provide such WebApi coverage that by fixture(s) creates a shared catalog - this would just verify the shared catalog as a concept that is build on top of the catalog permisssions
  All builds are green

Related Pull Requests

1. Api functional tests on Shared catalog PR is:
   https://github.com/magento/partners-magento2b2b/pull/335
   and is continuation from PR
   https://github.com/magento/partners-magento2b2b/pull/96
2. For [GraphQL "categories" and "categoryList" do not consider Category Permissions configuration ] (GraphQL "categories" and "categoryList" do not consider Category Permissions configuration #29880) PRs are
   Categories permissions for "categories" and "categoryList" #29883
   https://github.com/magento/partners-magento2ee/pull/319
3. For Prices should be hidden from products query results when the category permissions chooses to hide them PR is
   magento/magento2#29926: Prices should be possibly hidden from products query results #29998
4. For Search should be disabled from products query when general configuration chooses to disabled it PRs are
   Search should be disabled from products query when general configuration chooses to disabled it #30118
   https://github.com/magento/partners-magento2ee/pull/337
5. For "Add to Cart" mutations in GraphQl should consider Catalog Permissions PRs are
   Add to Cart mutations in GraphQl should consider Catalog Permissions #30019
   https://github.com/magento/partners-magento2ee/pull/328

Other relater PRs are

1. Extract getting customer group id from context into its own class
   https://github.com/magento/partners-magento2ee/pull/326

2. Increase accuracy in the context isCustomer method
   Context "isCustomer" should return false for Admin and Integration tokens #29894

[m2-assistant]

Hi @nrkapoor. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @dani97. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
     Details

     If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @pmarjan. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
     Details

     If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[pmarjan]

Hello @nrkapoor, @cpartica

upon closer inspection of the related PRs to this ticket, I noticed that there is NO new schema that is specific to the shared catalog.

For example the schema.graphqls that has been added to the CatalogPermissionsGraphQl module does only extend two queries

• categoryList
• categories

and they are both specific to the catalog.

Thus no wonder, most of the coding relates to Catalog Permissions and can be found here:
https://github.com/magento/partners-magento2ee/pull/302

In attempt to put focus on differences and scope, I will further say that the title of this PR is inaccurate: catalog permissions are a thing on its own - and NOT only for the shared catalog.

So, can you please confirm: we do not have shared catalog specific graphql schema?

If so, probably it will be more clear separation of concerns to have specified tickets like:

a. GraphQL "categoryList" query does not consider Category Permissions configuration
b. GraphQL "categories" query does not consider Category Permissions configuration

Because, I think this is exactly what is missing and the PR tries to solve.

Also it will be consistent continuation of an earlier work on the same topic:

GraphQL product search does not consider Category Permissions configuration
#28563

[nrkapoor]

Hello @nrkapoor, @cpartica

upon closer inspection of the related PRs to this ticket, I noticed that there is NO new schema that is specific to the shared catalog.

For example the schema.graphqls that has been added to the CatalogPermissionsGraphQl module does only extend two queries

• categoryList
• categories

and they are both specific to the catalog.

Thus no wonder, most of the coding relates to Catalog Permissions and can be found here:
magento/partners-magento2ee#302

In attempt to put focus on differences and scope, I will further say that the title of this PR is inaccurate: catalog permissions are a thing on its own - and NOT only for the shared catalog.

So, can you please confirm: we do not have shared catalog specific graphql schema?

If so, probably it will be more clear separation of concerns to have specified tickets like:

a. GraphQL "categoryList" query does not consider Category Permissions configuration
b. GraphQL "categories" query does not consider Category Permissions configuration

Because, I think this is exactly what is missing and the PR tries to solve.

Also it will be consistent continuation of an earlier work on the same topic:

GraphQL product search does not consider Category Permissions configuration
#28563

@pmarjan it has to also support products query.

[pmarjan]

@nrkapoor

products query - done! :)

#28563