Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1795: [MFTF] Unskip AdminMediaGalleryCatalogUiUsedInProductFilterTest #29909

Merged
merged 6 commits into from
Sep 14, 2020
Merged

#1795: [MFTF] Unskip AdminMediaGalleryCatalogUiUsedInProductFilterTest #29909

merged 6 commits into from
Sep 14, 2020

Conversation

joweecaquicla
Copy link

@joweecaquicla joweecaquicla commented Sep 4, 2020 •
edited
Loading

Description (*)

Unskipped AdminMediaGalleryCatalogUiUsedInProductFilterTest and will run MFTF builds to check and confirm that the test is stable. This PR will also fix the random failing issue with AdminMediaGallerySortByDirectoryDescendingTest

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes [MFTF] Unskip AdminMediaGalleryCatalogUiUsedInProductFilterTest adobe-stock-integration#1795
  2. Fixes [MFTF] AdminMediaGallerySortByDirectoryAscendingTest randomly failing adobe-stock-integration#1815

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1795: [MFTF] Unskip AdminMediaGallery…
80c1f3c 
…CatalogUiUsedInProductFilterTest - modified test and actiongroup
@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento/adobe-stock-integration#1795: [MFTF] Unskip AdminMediaGallery…
055ad7e 
…CatalogUiUsedInProductFilterTest - modified actiongroup
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento/adobe-stock-integration#1795: [MFTF] Unskip AdminMediaGallery…
a298f3b 
…CatalogUiUsedInProductFilterTest - modified test file
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento/adobe-stock-integration#1795: [MFTF] Unskip AdminMediaGallery…
c1410e7 
…CatalogUiUsedInProductFilterTest - modified sorting mftf tests
@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@joweecaquicla joweecaquicla changed the title [WIP] #1795: [MFTF] Unskip AdminMediaGalleryCatalogUiUsedInProductFilterTest #1795: [MFTF] Unskip AdminMediaGalleryCatalogUiUsedInProductFilterTest Sep 8, 2020
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Sep 8, 2020
sivaschenko
sivaschenko previously approved these changes Sep 9, 2020
View reviewed changes
@ghost ghost assigned sivaschenko Sep 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8167 has been created to process this Pull Request

@sivaschenko
Copy link
Member

The failed AdminMediaGalleryAssertUsedInLinkPagesGridTest appears to be randomly failing, will be skipped and fixed in the scope of a separate issue

@gabrieldagama
Copy link
Contributor

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

@sivaschenko
Copy link
Member

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

@sivaschenko
Copy link
Member

AdminMediaGalleryCatalogUiVerifyUsedInLinkProductGridTest and AdminMediaGalleryCatalogUiUsedInCategoryFilterTest have failed on this PR, created a separate ticket to stabilize them magento/adobe-stock-integration#1830

@sivaschenko
Copy link
Member

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

@sidolov sidolov added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Sep 14, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 14, 2020
@sidolov
ENGCOM-8167: #1795: [MFTF] Unskip AdminMediaGalleryCatalogUiUsedInPro…
f02a0f2 
…ductFilterTest #29909
@magento-engcom-team magento-engcom-team merged commit 2c462c8 into magento:2.4-develop Sep 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@gabrieldagama gabrieldagama Awaiting requested review from gabrieldagama

Assignees

@sivaschenko sivaschenko

@gabrieldagama gabrieldagama

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: MediaGalleryCatalogUi Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
5 participants
@joweecaquicla @magento-engcom-team @gabrieldagama @sivaschenko @sidolov