Fix issue when can't remove layout update after add during new widget creation #29991

saphaljha · 2020-09-11T05:34:23Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes item layout updates can't remove after add when create new widget #29936

Manual testing scenarios (*)

Manually tested by adding and removing the elements in new widget as well as in old widget

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-09-11T05:34:26Z

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

saphaljha · 2020-09-11T05:35:23Z

@magento run all tests

saphaljha · 2020-09-11T07:27:06Z

@magento run Functional Tests CE, Functional Tests EE, WebAPI Tests

rogyar · 2020-09-11T08:16:57Z

lib/internal/Magento/Framework/View/Helper/SecureHtmlRenderer.php

-                        targetElement = event.target;
+            var {$elementName}Array = document.querySelectorAll("{$elementSelector}");
+
+            {$elementName}Array.forEach(function(element){


We need to make sure that document.querySelectorAll will return an empty node list if there's no {$elementSelector} on the page. @saphaljha have you tested this scenario?

@rogyar , Thank you for suggestion, I have updated the code for validate empty nodeList. Also, covered MFTF.

rogyar · 2020-09-11T08:18:55Z

Hi @saphaljha. Thank you for your collaboration. Please, check my comment above. Also, I would ask you to cover your fix with an MFTF test. The MFTF test should basically emulate all the steps from "steps to reproduce" and check if it is possible to remove items other than the first one.

Thank you!

saphaljha · 2020-09-12T14:39:45Z

@magento run all tests

rogyar · 2020-09-15T11:48:10Z

...Magento/Widget/Test/Mftf/ActionGroup/AdminCreateAndDeleteMultipleLayoutWidgetActionGroup.xml

+<actionGroups
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminCreateAndDeleteMultipleLayoutWidgetActionGroup">


Hi @saphaljha. Great work! Thank you for the coverage.
We may improve this action group by splitting it into more atomic action groups. The main reason of it is the following. The purpose of the current action group is very specific and it might not be reused in many cases. In the meantime, we could split this huge action group into pieces like action group that creates widget, action group that deletes widget, action group that asserts number elements. In this case the smaller action groups will be much more reusable. Also, it's a good idea to double-check if we could reuse the existing action groups for adding/removing widgets.

Hope it makes sense.

Thank you!

Thank you @rogyar ,
I have updated it MFTF as per your suggestions, Please check and let me know if there is anything.

magento-engcom-team · 2020-12-04T08:53:32Z

Hi @rogyar, thank you for the review.
ENGCOM-8514 has been created to process this Pull Request

engcom-Bravo · 2020-12-04T14:52:44Z

✔️ QA Passed

Manual testing scenario

From Admin, go to Content - Widget click Add Widget
Select, for example,

Type - CMS Page Link
Design Theme - Magento Luma
Click Continue

Using Add Layout Update button, Add 3 Layout Updates, for example
Try to remove the added Layouts using the Remove Layout Update (basket)

BEFORE applying changes provided in this PR, only the first Layout Update could be removed

AFTER switching to the PR, all the Layout Updates can be removed

The Widget can be saved successfully

saphaljha · 2020-12-18T16:33:44Z

@magento Hello

…ng new widget creation #29991

m2-assistant · 2020-12-21T02:40:02Z

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fixed issue when using dynamic elements

7d6f8bb

ghost added the Progress: pending review label Sep 11, 2020

magento-engcom-team added Component: View Release Line: 2.4 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Sep 11, 2020

ihor-sviziev changed the title ~~Fixed issue 29936~~ Fix can't remove layout update after add when create new widget Sep 11, 2020

ihor-sviziev changed the title ~~Fix can't remove layout update after add when create new widget~~ Fix issue when can't remove layout update after add during new widget creation Sep 11, 2020

rogyar reviewed Sep 11, 2020

View reviewed changes

rogyar self-assigned this Sep 11, 2020

rogyar added Award: bug fix Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Sep 11, 2020

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. and removed Priority: P3 May be fixed according to the position in the backlog. labels Sep 11, 2020

Updated code for validate empty nodeList and covered MFTF

1f0fe69

ghost assigned saphaljha Sep 12, 2020

saphaljha requested a review from rogyar September 13, 2020 03:42

rogyar reviewed Sep 15, 2020

View reviewed changes

rogyar added Award: MFTF test coverage Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Sep 15, 2020

mrtuvn mentioned this pull request Sep 30, 2020

Fix missing escape Url method #30008

Merged

5 tasks

m2-community-project bot added Progress: review and removed Progress: pending review labels Dec 3, 2020

rogyar approved these changes Dec 4, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Dec 4, 2020

magento-engcom-team added the Component: Widget label Dec 4, 2020

m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Dec 4, 2020

engcom-Bravo self-assigned this Dec 4, 2020

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Dec 4, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 4, 2020

m2-community-project bot added the Progress: accept label Dec 4, 2020

magento-engcom-team mentioned this pull request Dec 21, 2020

item layout updates can't remove after add when create new widget #29936

Closed

5 tasks

magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2020

ENGCOM-8514: Fix issue when can't remove layout update after add duri…

bf9ee89

…ng new widget creation #29991

magento-engcom-team merged commit 221a88a into magento:2.4-develop Dec 21, 2020

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue when can't remove layout update after add during new widget creation #29991

Fix issue when can't remove layout update after add during new widget creation #29991

saphaljha commented Sep 11, 2020 •

edited

Loading

m2-assistant bot commented Sep 11, 2020

saphaljha commented Sep 11, 2020

saphaljha commented Sep 11, 2020

rogyar Sep 11, 2020

saphaljha Sep 12, 2020

rogyar commented Sep 11, 2020

saphaljha commented Sep 12, 2020

rogyar Sep 15, 2020

saphaljha Oct 21, 2020

magento-engcom-team commented Dec 4, 2020

engcom-Bravo commented Dec 4, 2020

saphaljha commented Dec 18, 2020

m2-assistant bot commented Dec 21, 2020

Fix issue when can't remove layout update after add during new widget creation #29991

Fix issue when can't remove layout update after add during new widget creation #29991

Conversation

saphaljha commented Sep 11, 2020 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Sep 11, 2020

saphaljha commented Sep 11, 2020

saphaljha commented Sep 11, 2020

rogyar Sep 11, 2020

Choose a reason for hiding this comment

saphaljha Sep 12, 2020

Choose a reason for hiding this comment

rogyar commented Sep 11, 2020

saphaljha commented Sep 12, 2020

rogyar Sep 15, 2020

Choose a reason for hiding this comment

saphaljha Oct 21, 2020

Choose a reason for hiding this comment

magento-engcom-team commented Dec 4, 2020

engcom-Bravo commented Dec 4, 2020

Manual testing scenario

saphaljha commented Dec 18, 2020

m2-assistant bot commented Dec 21, 2020

saphaljha commented Sep 11, 2020 •

edited

Loading