#30388 : fix js error on edit review page

[sunilit42]

fix issue :- #30388

[m2-assistant]

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sunilit42]

@magento run all tests

[vijay-wagento]

#dmcdindia2020

[rogyar]

Hi @sunilit42. Thank you for providing the fix. According to the definition of done all changes should be covered by autotests. Could I ask you to cover your changes with an MFTF test, please?

Thank you!

[rogyar]

@magento run all tests

[sunilit42]

@rogyar do i need to do any thing?

[rogyar]

Hi @sunilit42. Please, ignore my comment regarding MFTF tests. I don't think we can cover this case with auto tests.
Could you provide, please, more info about the testing scenario? I assume that the issue is reproducible only when single store mode is enabled, is this assumption correct?

Thanks

[sunilit42]

@rogyar it is happen with mutiple store as well

just add review and then go for edit review

#30388

[rogyar]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @rogyar, here is your Magento Instance: https://9157f027d03b2fbc2ddcd58098b12242-2-4-develop.instances.magento-community.engineering
Admin access: https://9157f027d03b2fbc2ddcd58098b12242-2-4-develop.instances.magento-community.engineering/admin_cbae
Login: 07683743
Password: 09c48f25f8bf

[rogyar]

@magento give me test instance

[magento-deployment-service]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @rogyar, here is your Magento Instance: https://9157f027d03b2fbc2ddcd58098b12242.instances.magento-community.engineering
Admin access: https://9157f027d03b2fbc2ddcd58098b12242.instances.magento-community.engineering/admin_6386
Login: d5f6d4c5
Password: 6a36a577893f

[rogyar]

Hi @sunilit42. Thanks for the clarification. The fix works well for me.
We usually ask to cover all fixes by automated tests. But in this particular case, I'm not sure we can create coverage since I don't see a broken functionality except for the console error. So, nothing to assert, basically.

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8354 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Precondition:

Have at least 1 review in the grid

Manual testing scenario:

1. Login to admin
2. Go to menu Marketing -> All Reivews
3. Try to edit any order

Before: ✖️ JS console error - Uncaught TypeError: Event.observe is not a function

After: ✔️ Working review edit

All functionalities, related to review, work as expected

[m2-assistant]

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.