Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed 'cache:flush' command from tests #30996

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Removed 'cache:flush' command from tests #30996

merged 3 commits into from
Dec 21, 2020

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Nov 20, 2020 •
edited by m2-assistant bot
Loading

Description

Remove 'cache:flush' command from tests to improve execution time for the following modules:

  • Catalog
  • CatalogUrlRewrite
  • LoginAsCustomer

Resolved issues:

  1. resolves [Issue] Removed 'cache:flush' command from tests #31056: Removed 'cache:flush' command from tests

@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@ihor-sviziev
Copy link
Contributor

@lbajsarowicz you would love it!

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE

@ihor-sviziev
Copy link
Contributor

Hi @sergiy-v,
Now functional tests are passing, so seems like your changes are good. Are you going to do something more in this PR?

@rogyar rogyar self-assigned this Nov 22, 2020
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Nov 22, 2020
@rogyar
Copy link
Contributor

rogyar commented Nov 22, 2020

Hi @sergiy-v. Thank you for grabbing this idea. Could you, please, specify in the description what modules were updated within the scope of this task?

Thanks.

@sergiy-v sergiy-v changed the title [WIP] Removed 'cache:flush' command from tests Removed 'cache:flush' command from tests Nov 23, 2020
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Nov 23, 2020 •
edited
Loading

Hi @sergiy-v,
Now functional tests are passing, so seems like your changes are good. Are you going to do something more in this PR?

Hello @ihor-sviziev. Thank you for re running 'Functional Tests EE'! I'm done with the changes in scope of this PR.

Hi @sergiy-v. Thank you for grabbing this idea. Could you, please, specify in the description what modules were updated within the scope of this task?

Hello @rogyar. Thank you for the suggestion, I have added the module list for this changes to the PR description.

Thank you.

ihor-sviziev
ihor-sviziev approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
✔ Approved from my side

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Nov 23, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8484 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Nov 23, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Nov 26, 2020
@sivaschenko sivaschenko moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 26, 2020
@sivaschenko sivaschenko removed their assignment Nov 26, 2020
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Nov 26, 2020
@sivaschenko sivaschenko moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Nov 26, 2020
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@lbajsarowicz
Copy link
Contributor

@magento run Functional Tests B2B

Ridiculous o.O

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@sergiy-v
Merge branch '2.4-develop' into mftf-cache-flush-command-improvements
551dd3f 
# Conflicts:
#	app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerMultishippingLoggingTest.xml
@sergiy-v
Copy link
Contributor Author

@magento run all tests

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 15, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2020
@sidolov
ENGCOM-8484: Removed 'cache:flush' command from tests #30996
2d9c832
@magento-engcom-team magento-engcom-team merged commit 4446284 into magento:2.4-develop Dec 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@rogyar rogyar rogyar approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Component: CatalogUrlRewrite Component: LoginAsCustomer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed 'cache:flush' command from tests
9 participants
@sergiy-v @ihor-sviziev @rogyar @magento-engcom-team @engcom-Alfa @engcom-Foxtrot @lbajsarowicz @sivaschenko @gabrieldagama