Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed 'cache:flush' command from tests #30996

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Removed 'cache:flush' command from tests #30996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff2451b
Removed 'cache:flush' commands from tests
sergiy-v Nov 20, 2020
dc02c0a
Merge branch '2.4-develop' into mftf-cache-flush-command-improvements
engcom-Foxtrot Dec 8, 2020
551dd3f
Merge branch '2.4-develop' into mftf-cache-flush-command-improvements
sergiy-v Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Test/Mftf/Test/StorefrontOnlyXProductLeftForSimpleProductsTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<requiredEntity createDataKey="createCategory"/>
</createData>
<magentoCLI command="config:set {{CatalogInventoryOptionsOnlyXleftThreshold.path}} 10000" stepKey="setStockThresholdQty"/>
<magentoCLI command="cache:flush config" stepKey="flushCache"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCache"/>
</before>
<after>
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
Expand Down
4 changes: 2 additions & 2 deletions ...lRewrite/Test/Mftf/Test/AdminVerifyCheckboxIsDisabledCreatePermanentRedirectSetNoTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</annotations>
<before>
<magentoCLI command="config:set {{DisableCreatePermanentRedirect.path}} {{DisableCreatePermanentRedirect.value}}" stepKey="enableCreatePermanentRedirect"/>
<magentoCLI command="cache:flush" stepKey="flushCache"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCache"/>
<createData entity="_defaultCategory" stepKey="createDefaultCategory"/>
<createData entity="SimpleProduct" stepKey="createSimpleProduct">
<requiredEntity createDataKey="createDefaultCategory"/>
Expand All @@ -29,7 +29,7 @@
<deleteData createDataKey="createSimpleProduct" stepKey="deleteSimpleProduct"/>
<deleteData createDataKey="createDefaultCategory" stepKey="deleteDefaultCategory"/>
<magentoCLI command="config:set {{EnableCreatePermanentRedirect.path}} {{EnableCreatePermanentRedirect.value}}" stepKey="disableCreatePermanentRedirect"/>
<magentoCLI command="cache:flush" stepKey="flushCache"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCache"/>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
</after>
<actionGroup ref="AdminProductPageOpenByIdActionGroup" stepKey="goToProductEditPage">
Expand Down
4 changes: 2 additions & 2 deletions ...e/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerAddProductToWishlistTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="_defaultCategory" stepKey="createCategory"/>
<createData entity="SimpleProduct" stepKey="createSimpleProduct">
<requiredEntity createDataKey="createCategory"/>
Expand All @@ -38,7 +38,7 @@
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Admin Login as Customer from Customer page -->
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerAutoDetectionTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<magentoCLI
command="config:set {{StorefrontEnableAddStoreCodeToUrls.path}} {{StorefrontEnableAddStoreCodeToUrls.value}}"
stepKey="enableAddStoreCodeToUrls"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="adminLogin"/>
<actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createCustomStoreView"/>
</before>
Expand All @@ -43,7 +43,7 @@
<magentoCLI
command="config:set {{StorefrontDisableAddStoreCodeToUrls.path}} {{StorefrontDisableAddStoreCodeToUrls.value}}"
stepKey="disableAddStoreCodeToUrls"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login as Customer from Customer page -->
Expand Down
4 changes: 2 additions & 2 deletions ...agento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerDirectlyToCustomWebsiteTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<magentoCLI
command="config:set {{StorefrontEnableAddStoreCodeToUrls.path}} {{StorefrontEnableAddStoreCodeToUrls.value}}"
stepKey="enableAddStoreCodeToUrls"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="adminLogin"/>
<actionGroup ref="AdminCreateWebsiteActionGroup" stepKey="createCustomWebsite">
<argument name="newWebsiteName" value="{{customWebsite.name}}"/>
Expand Down Expand Up @@ -60,7 +60,7 @@
<magentoCLI
command="config:set {{StorefrontDisableAddStoreCodeToUrls.path}} {{StorefrontDisableAddStoreCodeToUrls.value}}"
stepKey="disableAddStoreCodeToUrls"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login as Customer from Customer page -->
Expand Down
4 changes: 2 additions & 2 deletions ...e/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerEditCustomersAddressTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="Simple_US_Customer_Assistance_Allowed" stepKey="createCustomer"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAdmin"/>
</before>
Expand All @@ -32,7 +32,7 @@
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login as Customer Login from Customer page -->
Expand Down
2 changes: 1 addition & 1 deletion ...sCustomer/Test/Mftf/Test/AdminLoginAsCustomerLogNotShownIfLoginAsCustomerDisabledTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</annotations>
<before>
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0" stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
</before>
<after>
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerLoggingTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="NewAdminUser" stepKey="createNewAdmin"/>
<createData entity="Simple_US_Customer_Assistance_Allowed" stepKey="createFirstCustomer"/>
<createData entity="Simple_US_CA_Customer_Assistance_Allowed" stepKey="createSecondCustomer"/>
Expand All @@ -40,7 +40,7 @@
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutAfter"/>
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login into First Customer account -->
Expand Down
4 changes: 2 additions & 2 deletions ...ento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerManualChooseFromOrderPageTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 1"
stepKey="enableLoginAsCustomerManualChoose"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="adminLogin"/>
<actionGroup ref="AdminCreateNewStoreGroupActionGroup" stepKey="createCustomStore">
<argument name="website" value="{{_defaultWebsite.name}}"/>
Expand All @@ -54,7 +54,7 @@
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerManualChooseTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 1"
stepKey="enableLoginAsCustomerManualChoose"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="adminLogin"/>
<actionGroup ref="AdminCreateNewStoreGroupActionGroup" stepKey="createCustomStore">
<argument name="website" value="{{_defaultWebsite.name}}"/>
Expand All @@ -50,7 +50,7 @@
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
</after>

Expand Down
4 changes: 2 additions & 2 deletions ...e/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerMultishippingLoggingTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="SimpleProduct2" stepKey="createProduct1"/>
<createData entity="SimpleProduct2" stepKey="createProduct2"/>
<createData entity="Simple_US_Customer_Assistance_Allowed_Two_Addresses" stepKey="createCustomer"/>
Expand All @@ -44,7 +44,7 @@
<actionGroup ref="AdminOrdersGridClearFiltersActionGroup" stepKey="clearAllOrdersGridFilters"/>
<actionGroup ref="AdminLogoutActionGroup" stepKey="adminLogout"/>
<magentoCLI command="config:set {{DisableFreeShippingMethod.path}} {{DisableFreeShippingMethod.value}}" stepKey="disableFreeShipping"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login as Customer from Customer page -->
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerPlaceOrderTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="_defaultCategory" stepKey="createCategory"/>
<createData entity="SimpleProduct" stepKey="createProduct">
<requiredEntity createDataKey="createCategory"/>
Expand Down Expand Up @@ -59,7 +59,7 @@

<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login as Customer from Customer page -->
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerReorderTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="_defaultCategory" stepKey="createCategory"/>
<createData entity="SimpleProduct" stepKey="createProduct">
<requiredEntity createDataKey="createCategory"/>
Expand Down Expand Up @@ -59,7 +59,7 @@

<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login to storefront as Customer -->
Expand Down
4 changes: 2 additions & 2 deletions .../Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerSubscribeToNewsletterTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="Simple_US_Customer_Assistance_Allowed" stepKey="createCustomer"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
</before>
<after>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Admin Login as Customer from Customer page -->
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerUserLogoutTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="Simple_US_Customer_Assistance_Allowed" stepKey="createCustomer"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsDefaultUser"/>
</before>
Expand All @@ -33,7 +33,7 @@
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutAfter"/>
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login into Customer account -->
Expand Down
4 changes: 2 additions & 2 deletions ...code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerUserSingleSessionTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 1" stepKey="enableLoginAsCustomer"/>
<magentoCLI command="config:set {{LoginAsCustomerStoreViewLogin.path}} 0"
stepKey="enableLoginAsCustomerAutoDetection"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheBeforeTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheBeforeTestRun"/>
<createData entity="Simple_US_Customer_Assistance_Allowed" stepKey="createFirstCustomer"/>
<createData entity="Simple_US_CA_Customer_Assistance_Allowed" stepKey="createSecondCustomer"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsDefaultUser"/>
Expand All @@ -33,7 +33,7 @@
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutAfter"/>
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0"
stepKey="disableLoginAsCustomer"/>
<magentoCLI command="cache:flush config" stepKey="flushCacheAfterTestRun"/>
<comment userInput="Adding the comment to replace 'cache:flush' command for preserving Backward Compatibility" stepKey="flushCacheAfterTestRun"/>
</after>

<!-- Login into First Customer account -->
Expand Down
Loading