-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CatalogImportExport/Model/Import/Product->uploadMediaFiles #31118
Conversation
…roduct->uploadMediaFiles(…) to only log an error if the file doesn't already exist on the system Update app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/ProductTest->testUploadMediaFiles(…) to account for the above refactoring
Hi @Lunaetic. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @Lunaetic, thank you for your contribution! |
Hi @Lunaetic. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
(I closed and reopened as requested due to me not having signed the CLA) |
Hi @Lunaetic, thank you for your contribution! |
Description (*)
Refactors CatalogImportExport/Model/Import/Product->uploadMediaFiles to check if the file that was was not moved already exists on the filesystem. If the file does exist on the filesystem, no critical log entry is created, during the exception catch, since no error has actually occurred.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
21 Click on the "Choose File" button
Questions or comments
Contribution checklist (*)