MC-36425: “Select Shipping Method” page of Multishipping Checkout is corrupted if a Customer use “go back” browser button to return to the page #31156

engcom-Kilo · 2020-12-03T15:53:42Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes “Select Shipping Method” page of Multishipping Checkout is corrupted if a Customer use “go back” browser button to return to the page #30268

Manual testing scenarios (*)

see “Select Shipping Method” page of Multishipping Checkout is corrupted if a Customer use “go back” browser button to return to the page #30268

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-12-03T15:53:44Z

Hi @engcom-Kilo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

…corrupted if a Customer use “go back” browser button to return to the page

rogyar · 2020-12-04T08:43:20Z

...tishipping/Test/Mftf/Test/StorefrontCreateOrderWithMultishippingAfterReturningToCartTest.xml

+            <!--Clean up test data, revert configuration.-->
+            <deleteData createDataKey="product" stepKey="deleteProduct"/>
+            <deleteData createDataKey="customer" stepKey="deleteCustomer"/>
+            <magentoCLI command="config:set {{DisableFreeShippingMethod.path}} {{DisableFreeShippingMethod.value}}" stepKey="disableFreeShipping"/>


That's so awesome that we don't clean cache anymore after setting a config via CLI anymore (it's invalidated automatically in this case).

Great job!

engcom-Kilo · 2020-12-04T13:08:31Z

@magento run all tests

zakdma · 2020-12-07T11:20:17Z

...tishipping/Test/Mftf/Test/StorefrontCreateOrderWithMultishippingAfterReturningToCartTest.xml

+            <title value="Checkout with multiple addresses after returning on cart page during checkout."/>
+            <description value="Verify customer able to checkout with multiple addresses after returning to cart page and continue checkout with browser 'back' button."/>
+            <severity value="AVERAGE"/>
+            <testCaseId value="MC-39583"/>


Please add MC-39583 as has tests link to task
Please specify test Path in MC-39583 zephyr
Please add Expected result for steps in MC-39583 zephyr

zakdma · 2020-12-07T11:21:11Z

...tishipping/Test/Mftf/Test/StorefrontCreateOrderWithMultishippingAfterReturningToCartTest.xml

+        </after>
+
+        <!--Add product to cart and proceed to multishipping checkout. -->
+        <actionGroup ref="LoginToStorefrontActionGroup" stepKey="loginToStorefrontAccount">


Please add logout in after section but before customer delete

zakdma · 2020-12-07T11:21:42Z

...tishipping/Test/Mftf/Test/StorefrontCreateOrderWithMultishippingAfterReturningToCartTest.xml

+
+        <!--Add product to cart and proceed to multishipping checkout. -->
+        <actionGroup ref="LoginToStorefrontActionGroup" stepKey="loginToStorefrontAccount">
+            <argument name="Customer" value="$$customer$$"/>


Please dont use $$. Use single $ instead

zakdma · 2020-12-07T11:50:49Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2020-12-07T11:53:17Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31156.

…corrupted if a Customer use “go back” browser button to return to the page

zakdma · 2020-12-07T12:20:12Z

@magento run all tests

zakdma · 2020-12-07T14:19:22Z

@magento run all tests

engcom-Bravo · 2020-12-07T15:12:11Z

✔️ QA Passed

Manual testing scenario

Go to the Storefront as the created Customer
Add the created Product (2pcs) to the Shopping Cart
Open the mini-cart
Click the {color:#0747a6}“View and Edit Cart”{color} link
Click the “{color:#0747a6}Check Out with Multiple Addresses”{color} link
Select shipping addresses
Click the “Go to Shipping Information” button
Select Flat Rate shipping method
Click the “Continue to Billing Information” button
Click the "Add or remove gift cards" link on the “Billing Information” page
Wait until the “Shopping Cart” page is loaded completely
Click the “go back” browser button (left arrow)
Click the {color:#0747a6}”Back to Shipping Information” link on the “Billing Information” page

BEFORE applying changes provided in the PR, the web page was not fully loaded, and an Exception appeared

AFTER switching to the PR, the page is fully loaded with no errors

The order can be placed successfully

zakdma · 2020-12-07T17:56:30Z

@magento run Functional Tests EE, Integration Tests

zakdma · 2020-12-07T22:17:10Z

@magento run Functional Tests B2B

zakdma · 2020-12-08T05:19:13Z

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

zakdma · 2020-12-08T07:48:12Z

@magento run Functional Tests B2B, Functional Tests EE

zakdma · 2020-12-09T10:34:55Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2020-12-09T10:37:18Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31156.

zakdma · 2020-12-09T10:54:25Z

@magento run all tests

zakdma · 2020-12-09T12:00:15Z

@magento run Functional Tests CE

zakdma · 2020-12-14T08:22:54Z

Changes was delivered in scope of internal ticket MC-36425

m2-assistant · 2020-12-14T08:22:56Z

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Component: Multishipping Release Line: 2.4 labels Dec 3, 2020

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 3, 2020

m2-community-project bot added the Progress: pending review label Dec 3, 2020

MC-36425: “Select Shipping Method” page of Multishipping Checkout is …

8b00562

…corrupted if a Customer use “go back” browser button to return to the page

engcom-Kilo force-pushed the MC-36425 branch from fc0916a to 8b00562 Compare December 3, 2020 18:55

rogyar reviewed Dec 4, 2020

View reviewed changes

m2-community-project bot assigned rogyar Dec 4, 2020

m2-community-project bot added Progress: review and removed Progress: pending review labels Dec 4, 2020

rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 4, 2020

Merge branch '2.4-develop' into MC-36425

8be1aa2

zakdma suggested changes Dec 7, 2020

View reviewed changes

m2-community-project bot assigned zakdma Dec 7, 2020

m2-community-project bot added Progress: needs update and removed Progress: review labels Dec 7, 2020

Merge remote-tracking branch 'origin/2.4-develop' into MC-36425

b895fba

MC-36425: “Select Shipping Method” page of Multishipping Checkout is …

7485401

…corrupted if a Customer use “go back” browser button to return to the page

zakdma self-requested a review December 7, 2020 13:58

zakdma approved these changes Dec 7, 2020

View reviewed changes

engcom-Bravo self-assigned this Dec 7, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 7, 2020

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Dec 7, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Dec 7, 2020

m2-community-project bot added the Progress: extended testing label Dec 7, 2020

Merge remote-tracking branch 'origin/2.4-develop' into MC-36425

c2424ce

zakdma closed this Dec 14, 2020

m2-community-project bot removed Progress: extended testing Progress: ready for testing labels Dec 14, 2020

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MC-36425: “Select Shipping Method” page of Multishipping Checkout is corrupted if a Customer use “go back” browser button to return to the page #31156

MC-36425: “Select Shipping Method” page of Multishipping Checkout is corrupted if a Customer use “go back” browser button to return to the page #31156

engcom-Kilo commented Dec 3, 2020

m2-assistant bot commented Dec 3, 2020

rogyar Dec 4, 2020 •

edited

Loading

engcom-Kilo commented Dec 4, 2020

zakdma Dec 7, 2020

zakdma Dec 7, 2020

zakdma Dec 7, 2020

zakdma commented Dec 7, 2020

magento-engcom-team commented Dec 7, 2020

zakdma commented Dec 7, 2020

zakdma commented Dec 7, 2020

engcom-Bravo commented Dec 7, 2020 •

edited

Loading

zakdma commented Dec 7, 2020

zakdma commented Dec 7, 2020

zakdma commented Dec 8, 2020

zakdma commented Dec 8, 2020

zakdma commented Dec 9, 2020

magento-engcom-team commented Dec 9, 2020

zakdma commented Dec 9, 2020

zakdma commented Dec 9, 2020

zakdma commented Dec 14, 2020

m2-assistant bot commented Dec 14, 2020

MC-36425: “Select Shipping Method” page of Multishipping Checkout is corrupted if a Customer use “go back” browser button to return to the page #31156

MC-36425: “Select Shipping Method” page of Multishipping Checkout is corrupted if a Customer use “go back” browser button to return to the page #31156

Conversation

engcom-Kilo commented Dec 3, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Dec 3, 2020

rogyar Dec 4, 2020 • edited Loading

Choose a reason for hiding this comment

engcom-Kilo commented Dec 4, 2020

zakdma Dec 7, 2020

Choose a reason for hiding this comment

zakdma Dec 7, 2020

Choose a reason for hiding this comment

zakdma Dec 7, 2020

Choose a reason for hiding this comment

zakdma commented Dec 7, 2020

magento-engcom-team commented Dec 7, 2020

zakdma commented Dec 7, 2020

zakdma commented Dec 7, 2020

engcom-Bravo commented Dec 7, 2020 • edited Loading

Manual testing scenario

zakdma commented Dec 7, 2020

zakdma commented Dec 7, 2020

zakdma commented Dec 8, 2020

zakdma commented Dec 8, 2020

zakdma commented Dec 9, 2020

magento-engcom-team commented Dec 9, 2020

zakdma commented Dec 9, 2020

zakdma commented Dec 9, 2020

zakdma commented Dec 14, 2020

m2-assistant bot commented Dec 14, 2020

rogyar Dec 4, 2020 •

edited

Loading

engcom-Bravo commented Dec 7, 2020 •

edited

Loading