Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reference layout cms_noroute_index core #31299

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix reference layout cms_noroute_index core #31299

merged 1 commit into from
Feb 5, 2021

Conversation

PierW
Copy link
Member

@PierW PierW commented Dec 16, 2020 •
edited by m2-assistant bot
Loading

Description (*)

cms_index_noroute.xml, It turns out the file is named incorrectly in the core, the correct file name should be cms_noroute_index.xml

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Create Your custom theme
  2. Try to override the cms_index_noroute.xml layout inside Magento_Cms.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] fix reference layout cms_noroute_index core #31300: fix reference layout cms_noroute_index core

@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2020

Hi @PierW. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@PierW
Copy link
Member Author

PierW commented Dec 16, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 16, 2020
Closed
4 tasks
@PierW
Copy link
Member Author

PierW commented Dec 16, 2020

@magento run all tests

@swnsma swnsma self-requested a review December 17, 2020 10:00
@swnsma swnsma added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Dec 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-8550 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Dec 17, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Manual testing scenario:

  • Create custom module
  • Try to override the cms_index_noroute.xml layout inside Magento_Cms:
<?xml version="1.0"?>
<!--
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */
-->
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <body>
        <referenceBlock name="footer_links">
            <block class="Magento\Framework\View\Element\Html\Link\Current" ifconfig="contact/contact/enabled" name="contact-us-link">
                <arguments>
                    <argument name="label" xsi:type="string" translate="true">Contact Us Eddited</argument>
                    <argument name="path" xsi:type="string">contact</argument>
                </arguments>
            </block>
        </referenceBlock>
    </body>
</page>

❌ : Before:
Custom layout is not applied to noroute/index page

✔️ After:
Custom layout for cms_noroute_index.xml is applied to noroute/index page
#31299Pr

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Dec 18, 2020
@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

magento-engcom-team pushed a commit that referenced this pull request Feb 5, 2021
@gabrieldagama
ENGCOM-8550: fix reference layout cms_noroute_index core #31299
3a2d72d
@magento-engcom-team magento-engcom-team merged commit e6fc97a into magento:2.4-develop Feb 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2021

Hi @PierW, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swnsma swnsma swnsma approved these changes

Assignees

@swnsma swnsma

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Cms Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] fix reference layout cms_noroute_index core
4 participants
@PierW @magento-engcom-team @engcom-Delta @swnsma