Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CliCacheFlushActionGroup usage for CatalogRule #31859

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 27, 2021

Description

Removed usage or changed value of CliCacheFlushActionGroup action group for CatalogRule, Backend, Bundle and BundleImportExport modules.

Resolved issues:

  1. resolves [Issue] Removed CliCacheFlushActionGroup usage for CatalogRule #31860: Removed CliCacheFlushActionGroup usage for CatalogRule

…up for CatalogRule, Backend, Bundle and BundleImportExport modules
@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

@magento create issue

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@sergiy-v
Copy link
Contributor Author

@magento run WebAPI Tests, Unit Tests, Static Tests, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Magento Health Index, Integration Tests, Database Compare

@eduard13 eduard13 self-assigned this Jan 27, 2021
@eduard13 eduard13 self-requested a review January 27, 2021 17:47
@eduard13 eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 27, 2021
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@engcom-Bravo
Copy link
Contributor

Manual QA not applicable for MFTF refactoring PR. Moving this PR to Extending Testing column

@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Backend Component: Bundle Component: BundleImportExport Component: CatalogRule Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Type: Test Coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliCacheFlushActionGroup usage for CatalogRule
6 participants