MC-33893: 2.3.4 Invoice always sent (if exist) when order placed

[zakdma]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes 2.3.4 Invoice always sent (if exist) when order placed. #27656

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @zakdma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[zakdma]

@magento run all tests

[engcom-Kilo]

Please specify return type to method.

Suggested change

	public function execute(Observer $observer)
	public function execute(Observer $observer): void

[zakdma]

Not allowed to do that because declared interface method ObserverInterface::execute() have no such return type hinting.

[zakdma]

@magento run all tests

[zakdma]

@magento run all tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8965 has been created to process this Pull Request

[ihor-sviziev]

@zakdma thank you so much for making this as a public PR!

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests EE

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests EE

[dmitriyprime]

✔️ QA passed
Manual testing scenario:

• Configure payment method with Payment Action=Sale (e.g., Payflow Pro)
• Create simple product
• Login as registered customer
• Place order using Credit Card (Payflow Pro)

Before:

• Email with order information send.
• Email with invoice information send(no possibility to disable/customize behavior)

After:

• Email with order information send.

• Email with invoice information send - could be disabled or customize via observer sendInvoiceEmail

• • Email with invoice information is not sent if observer is disabled:

<event name="sales_model_service_quote_submit_success">
        <observer name="sendInvoiceEmail" disabled="true"/>
</event>

[zakdma]

@magento import code to https://github.com/magento-tsg/magento2ce

[magento-engcom-team]

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32580.

[m2-assistant]

Hi @zakdma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.