Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize loading of media gallery when editing a product #32818

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Optimize loading of media gallery when editing a product #32818

merged 3 commits into from
Aug 20, 2021

Conversation

blmage
Copy link
Contributor

@blmage blmage commented Apr 22, 2021 •
edited by m2-assistant bot
Loading

Description (*)

This PR aims to optimize the loading of the gallery tab when editing a product with many images, by avoiding redundant operations.

In a real-world example with a product with nearly 300 images, loading the gallery was more than 10 times faster after applying the changes.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Create a product.
  2. Add or import a hundred images.
  3. Edit the product again, opening the gallery tab is (very) slow.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Optimize loading of media gallery when editing a product #33434: Optimize loading of media gallery when editing a product

@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2021

Hi @blmage. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@blmage
Copy link
Contributor Author

blmage commented Apr 22, 2021

@magento run all tests

@blmage blmage closed this Apr 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2021

Hi @blmage, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@blmage blmage reopened this Apr 22, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 22, 2021

@magento run Static Tests, Integration Tests, Functional Tests EE, Functional Tests B2B

@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 23, 2021

@magento run Static Tests, Functional Tests B2B

@mrtuvn mrtuvn added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests improvement labels Apr 23, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 23, 2021

Can you cover your change with some js tests in jasmine
dev/tests/js/jasmine/tests/app/code/Magento/Catalog/adminhtml/js/product-gallery.test.js

@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 23, 2021

@magento run Unit Tests, Static Tests, Integration Tests, Functional Tests CE, Functional Tests EE

@mrtuvn mrtuvn added the Priority: P3 May be fixed according to the position in the backlog. label Apr 23, 2021
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 23, 2021
@mrtuvn mrtuvn added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Apr 23, 2021
@magento-automated-testing
Copy link

No builds to run for your request.

9 similar comments
@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@magento-automated-testing
Copy link

No builds to run for your request.

@Den4ik Den4ik added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 22, 2021
@m2-community-project m2-community-project bot removed this from Ready for Testing in Pull Requests Dashboard Jun 22, 2021
@engcom-Alfa engcom-Alfa self-assigned this Jul 4, 2021
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jul 4, 2021
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 7, 2021
Closed
5 tasks
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Jul 7, 2021
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jul 7, 2021 •
edited
Loading

✔️ QA Passed

Preconditions:

  1. Create a simple product; uploading ~100s of images while creating.

Manual testing scenario:

  1. Navigate to the Admin side product page.

  2. Search the product that is having ~100s of images. Click on Edit products.

  3. Click on Images and Videos tab section of the product edit page, and validate its response time.

Before: ✖️ Response time was around 2000ms for around 70 uploaded images

image

After: ✔️ Response time is around 650ms for around 70 uploaded images

image

The above scenario fulfills the testing coverage, and there is no additional regression require to process with as there in no impact to any other feature.

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jul 7, 2021
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Jul 7, 2021
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jul 8, 2021
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Jul 13, 2021
magento-engcom-team pushed a commit that referenced this pull request Aug 20, 2021
@gabrieldagama
ENGCOM-9068: Optimize loading of media gallery when editing a product #…
7371b0a 
…32818
@magento-engcom-team magento-engcom-team merged commit be26f09 into magento:2.4-develop Aug 20, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 20, 2021

Hi @blmage, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gabrieldagama gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@engcom-Alfa engcom-Alfa

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: category of expertise Award: complex Award: special achievement Component: Catalog improvement Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Optimize loading of media gallery when editing a product
5 participants
@blmage @mrtuvn @Den4ik @magento-engcom-team @engcom-Alfa