Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Optimize loading of media gallery when editing a product #33434

Closed
5 tasks
m2-assistant bot opened this issue Jul 7, 2021 · 1 comment · Fixed by #32818
Closed
5 tasks

[Issue] Optimize loading of media gallery when editing a product #33434

m2-assistant bot opened this issue Jul 7, 2021 · 1 comment · Fixed by #32818
Assignees
@blmage
Labels
Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 7, 2021

This issue is automatically created based on existing pull request: #32818: Optimize loading of media gallery when editing a product

Description (*)

This PR aims to optimize the loading of the gallery tab when editing a product with many images, by avoiding redundant operations.

In a real-world example with a product with nearly 300 images, loading the gallery was more than 10 times faster after applying the changes.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Create a product.
  2. Add or import a hundred images.
  3. Edit the product again, opening the gallery tab is (very) slow.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 7, 2021
@m2-assistant m2-assistant bot mentioned this issue Jul 7, 2021
Merged
6 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jul 7, 2021
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jul 7, 2021
@Den4ik Den4ik added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 7, 2021
@engcom-Alfa engcom-Alfa removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Jul 7, 2021
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Jul 7, 2021
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in High Priority Backlog Jul 7, 2021
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Progress: PR in progress and removed Issue: ready for confirmation labels Jul 7, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Jul 7, 2021
@engcom-Alfa engcom-Alfa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 7, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jul 7, 2021
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jul 7, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-42837 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blmage blmage

Labels
Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize loading of media gallery when editing a product blmage/magento2
4 participants
@Den4ik @blmage @magento-engcom-team @engcom-Alfa