Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label to page jump #33067

Merged
merged 7 commits into from Sep 23, 2021
Merged

Add aria-label to page jump #33067

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4400de6
Add aria-label to page jump
bradleybrecher Apr 18, 2021
0430a80
Add translation & escape verbiage
bradleybrecher May 28, 2021
345758e
Update escaping method and docblock
bradleybrecher May 31, 2021
d05b564
Merge branch '2.4-develop' into add-aria-links
Jun 16, 2021
3cf162b
Merge branch '2.4-develop' into add-aria-links
sdzhepa Jun 22, 2021
0b01c57
Merge branch '2.4-develop' into add-aria-links
sdzhepa Jul 1, 2021
b84bd72
Update previous jump label
Den4ik Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/code/Magento/Theme/view/frontend/templates/html/pager.phtml
View file
Open in desktop
Expand Up @@ -61,6 +61,7 @@
<li class="item">
<a class="page previous jump"
title=""
aria-label="Skip to page <?= $block->escapeHtml($block->getPreviousJumpPage()) ?>"
href="<?= $block->escapeUrl($block->getPreviousJumpUrl()) ?>">
<span>...</span>
</a>
Expand All @@ -87,7 +88,10 @@

<?php if ($block->canShowNextJump()): ?>
<li class="item">
<a class="page next jump" title="" href="<?= $block->escapeUrl($block->getNextJumpUrl()) ?>">
<a class="page next jump"
title=""
aria-label="Skip to page <?= $block->escapeHtml($block->getNextJumpPage()) ?>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you translate this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blmage can you clarify further what you mean by "translate this"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradleybrecher 'Skip to Page' should be translatable with __()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change pushed & ready for another review

href="<?= $block->escapeUrl($block->getNextJumpUrl()) ?>">
<span>...</span>
</a>
</li>
Expand Down