Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cls pdp screen #33265

Closed
wants to merge 28 commits into from
Closed

Improve cls pdp screen #33265

wants to merge 28 commits into from
+72 −68

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 17, 2021 •
edited by engcom-Lima

Description (*)

Some improvements on details page. Try to reduce as much as possible for CLS layout. Previously this page layout become shift when page loading or being initialized. Some element dymanic delay render in DOM caused jumping content -> Google penalized CLS metric

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento 2.4.2 CLS issue #32956
  2. Fixes Improve CLS on PDP 2.4.4 #35410

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. Fixes Magento 2.4.2 CLS issue #32956
  2. Fixes Improve CLS on PDP 2.4.4 #35410

@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jun 17, 2021
@mrtuvn mrtuvn force-pushed the improve-pdp-cls branch 3 times, most recently from c95cb32 to 1a692b7 Compare June 28, 2021 15:16
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 28, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 29, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 29, 2021

@magento run WebAPI Tests, Unit Tests, Static Tests, Sample Data Tests EE, Sample Data Tests B2B, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B, Database Compare

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn force-pushed the improve-pdp-cls branch 2 times, most recently from f21599e to 1aa677d Compare June 29, 2021 14:29
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 29, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn marked this pull request as ready for review July 1, 2021 07:12
@mrtuvn mrtuvn marked this pull request as draft July 2, 2021 15:44
@mrtuvn mrtuvn marked this pull request as ready for review July 5, 2021 02:43
@mrtuvn mrtuvn force-pushed the improve-pdp-cls branch 4 times, most recently from ac143c9 to 3ac64f7 Compare July 12, 2021 02:32
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 12, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

The 2 successive build results are showing different error failures for Functional CE, and Functional B2B. Hence moving this PR to Merge in Progress.

Functional CE: Run 1
image

Run 2:
image

Functional B2B: Run 1
image

Run 2:
image

@engcom-Charlie engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Aug 31, 2023
@m2-community-project m2-community-project bot moved this from Merge in Progress to Review in Progress in Community Dashboard Sep 7, 2023
@engcom-Charlie
Copy link
Contributor

It seems bot move this PR to Review hence moving it back to Merge in Progress.

@engcom-Charlie engcom-Charlie moved this from Review in Progress to Merge in Progress in Community Dashboard Sep 7, 2023
@engcom-Charlie
Copy link
Contributor

This PR got merged in 2.4-develop in b9f57bd commit. Hence closing this PR now.

@engcom-Charlie engcom-Charlie moved this from Merge in Progress to Recently Merged in Community Dashboard Oct 23, 2023
@m2-community-project m2-community-project bot removed this from Recently Merged in Community Dashboard Oct 23, 2023
@nkajic
Copy link
Member

nkajic commented Oct 23, 2023

859 days

@timpea-splat
Copy link

top work @mrtuvn!

This was referenced Mar 22, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

@kevalkavathiya kevalkavathiya kevalkavathiya approved these changes

@ptylek ptylek Awaiting requested review from ptylek

@larsroettig larsroettig Awaiting requested review from larsroettig

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

@engcom-Lima engcom-Lima

Labels
Area: Frontend Area: Perf/Frontend All tickets related with improving frontend performance. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Award: category of expertise Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Community Picked PRs upvoted by the community Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CLS on PDP 2.4.4 Magento 2.4.2 CLS issue