Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product gallery jump during page load #32316

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Mar 1, 2021

Description (*)

  • Position absolute will prevent page jumping
  • Move logic from JS to css (position absolute + z-index=-1 will render gallery on background)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Product gallery jumps while loading #32315

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 1, 2021

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests

Fix failing functional tests by updating the image selector
@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Mar 2, 2021

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests

@ihor-sviziev
Copy link
Contributor Author

@magento run Database Compare, Integration Tests, Magento Health Index, Sample Data Tests B2B, Sample Data Tests CE , Sample Data Tests EE, Semantic Version Checker, Unit Tests, WebAPI Tests

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Mar 2, 2021
@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-sviziev Thanks for your work.
Reproduced described steps in issue and fix locally. All looks good.

@ihor-sviziev
Copy link
Contributor Author

These changes were already merged in another pull request #33265 (comment)

@ihor-sviziev ihor-sviziev deleted the fix-gallery-jump-during-page-load branch March 22, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Award: bug fix Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product gallery jumps while loading
3 participants