Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CliCacheFlushActionGroup usage for CatalogSearch and other modules #33530

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jul 20, 2021

Description

Removed CliCacheFlushActionGroup usage for CatalogSearch, GroupedProduct, Newsletter, Paypal, Quote and Review modules.

Resolved issues:

  1. resolves [Issue] Removed CliCacheFlushActionGroup usage for CatalogSearch and other modules #33531: Removed CliCacheFlushActionGroup usage for CatalogSearch and other modules

…uct, Newsletter, Paypal, Quote and Review modules
@m2-assistant
Copy link

m2-assistant bot commented Jul 20, 2021

Hi @sergiy-v. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergiy-v
Copy link
Contributor Author

@magento create issue

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Copy link

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sergiy-v
Thank you for your contribution.
Changes are approved.
Waiting for finishing tests

@magento-engcom-team
Copy link
Contributor

Hi @andrewbess, thank you for the review.
ENGCOM-9156 has been created to process this Pull Request
✳️ @andrewbess, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@andrewbess andrewbess added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 20, 2021
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jul 29, 2021

Hi @sergiy-v,

Thank you for your contribution.

❌ QA not Passed

I have run all of the MFTF test cases from this PR on my local environment and found that 5 Broken(warning), 22 Successful.

Here is the Allure report for the same.

image

image

image

Below are the errors/warning I am getting. Can you please have a look on below warnings and confirm on those.

image

image

image

image

image

Thank you in advance!

@eduard13
Copy link
Contributor

eduard13 commented Aug 4, 2021

Hi @engcom-Charlie, it looks more like a env setup issue. Could you please double check it?
Thank you.

@sergiy-v
Copy link
Contributor Author

@magento run Integration Tests, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sergiy-v
Copy link
Contributor Author

Hello @engcom-Charlie,
Unfortunately I could not reproduce the errors you shared.
Please try one more time and in case of error provide a command how you are running MFTF tests.
Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-9156 has been created to process this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: CatalogSearch Component: GroupedProduct Component: Newsletter Component: Paypal Component: Quote Component: Review Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliCacheFlushActionGroup usage for CatalogSearch and other modules
5 participants