-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed CliCacheFlushActionGroup usage for CatalogSearch and other modules #33530
Removed CliCacheFlushActionGroup usage for CatalogSearch and other modules #33530
Conversation
…uct, Newsletter, Paypal, Quote and Review modules
Hi @sergiy-v. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento create issue |
@magento run Functional Tests CE,Semantic Version Checker |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sergiy-v
Thank you for your contribution.
Changes are approved.
Waiting for finishing tests
Hi @andrewbess, thank you for the review.
|
@magento run Functional Tests EE,Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @sergiy-v, Thank you for your contribution. ❌ QA not Passed I have run all of the MFTF test cases from this PR on my local environment and found that 5 Broken(warning), 22 Successful. Here is the Allure report for the same. Below are the errors/warning I am getting. Can you please have a look on below warnings and confirm on those. Thank you in advance! |
Hi @engcom-Charlie, it looks more like a env setup issue. Could you please double check it? |
@magento run Integration Tests, Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hello @engcom-Charlie, |
Hi @eduard13, thank you for the review. |
… and other modules #33530
Description
Removed CliCacheFlushActionGroup usage for CatalogSearch, GroupedProduct, Newsletter, Paypal, Quote and Review modules.
Resolved issues: