Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring StorefrontOrderPagerDisplayedTest #33571

Merged
merged 2 commits into from
Oct 23, 2021
Merged

[MFTF] Refactoring StorefrontOrderPagerDisplayedTest #33571

merged 2 commits into from
Oct 23, 2021

Conversation

AnnaAPak
Copy link
Contributor

The test is refactored to improve execution time

Related Pull Requests

#33557

Please, note: the test is dependent on #33557

@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2021

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak
Copy link
Contributor Author

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak AnnaAPak force-pushed the ref-StorefrontOrderPagerDisplayedTest branch from 0995036 to 3235565 Compare July 23, 2021 10:02
@AnnaAPak
Copy link
Contributor Author

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jul 25, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik self-assigned this Jul 25, 2021
@Den4ik Den4ik self-requested a review July 25, 2021 09:05
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Jul 25, 2021
@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 29, 2021
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Jul 29, 2021
@AnnaAPak AnnaAPak mentioned this pull request Aug 4, 2021
Merged
@sidolov
Copy link
Contributor

sidolov commented Oct 14, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Oct 17, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Oct 18, 2021
@sidolov sidolov moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Oct 18, 2021
@magento-engcom-team
Copy link
Contributor

@AnnaAPak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Oct 20, 2021
@Den4ik Den4ik added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: accept and removed Progress: ready for testing labels Oct 20, 2021
@m2-community-project m2-community-project bot moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Oct 20, 2021
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Oct 20, 2021
@Den4ik
Copy link
Contributor

Den4ik commented Oct 20, 2021

@AnnaAPak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@AnnaAPak Could you pay attention to this message

magento-engcom-team pushed a commit that referenced this pull request Oct 23, 2021
@sidolov
ENGCOM-9262: [MFTF] Refactoring StorefrontOrderPagerDisplayedTest #33571
6903934
@magento-engcom-team magento-engcom-team merged commit 4460a38 into magento:2.4-develop Oct 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov moved this from Ready for Testing to Recently Merged in High Priority Pull Requests Dashboard Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@Den4ik Den4ik

@sidolov sidolov

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Component: Quote Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AnnaAPak @Den4ik @sidolov @magento-engcom-team @sdzhepa