Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest #33557

Merged
merged 5 commits into from Jun 11, 2022
Merged

[MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest #33557

merged 5 commits into from Jun 11, 2022

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Jul 22, 2021 •
edited by m2-assistant bot

The test is refactored to improve execution time

Resolved issues:

  1. resolves [Issue] [MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest  #33692: [MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest

@m2-assistant
Copy link

m2-assistant bot commented Jul 22, 2021

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak
Copy link
Contributor Author

@magento run Semantic Version Checker, Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik self-requested a review July 22, 2021 08:29
@Den4ik Den4ik self-assigned this Jul 22, 2021
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Jul 22, 2021
@AnnaAPak AnnaAPak mentioned this pull request Jul 22, 2021
Open
@AnnaAPak AnnaAPak changed the title [MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest [WIP] [MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest Jul 22, 2021
@AnnaAPak
Copy link
Contributor Author

@Den4ik sorry, but I'm marking the PR as WIP as I have found some issues in it.
Thanks.

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak AnnaAPak force-pushed the ref-AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest branch from 1b75182 to deceabb Compare July 23, 2021 07:09
@AnnaAPak AnnaAPak changed the title [WIP] [MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest [MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest Jul 23, 2021
@AnnaAPak
Copy link
Contributor Author

It is ready for be reviewed. Thanks.

@AnnaAPak AnnaAPak mentioned this pull request Jul 23, 2021
Merged
@Den4ik
Copy link
Contributor

Den4ik commented Jul 23, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Jul 25, 2021

@magento run Integration Tests, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik
Den4ik approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Failed B2B test is not related to changes

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Jul 27, 2021
@engcom-Charlie engcom-Charlie moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Aug 5, 2021
@engcom-Charlie engcom-Charlie moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Aug 5, 2021
@eduard13 eduard13 self-assigned this Aug 12, 2021
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Aug 12, 2021
@m2-community-project m2-community-project bot moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Aug 12, 2021
@m2-community-project m2-community-project bot moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Aug 12, 2021
@AnnaAPak
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Oct 12, 2021

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Nov 7, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 6, 2022

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ishakhsuvarov
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 95ccfe6 into magento:2.4-develop Jun 11, 2022
@ishakhsuvarov ishakhsuvarov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@eduard13 eduard13

@engcom-Charlie engcom-Charlie

Labels
Component: Backend Component: Quote Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Refactoring AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest
8 participants
@AnnaAPak @Den4ik @engcom-Charlie @ishakhsuvarov @sdzhepa @eduard13 @magento-engcom-team @magento-devops-reposync-svc