Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] ZeroSubtotalOrdersWithProcessingStatusTest refactoring #33793

Merged
merged 3 commits into from
Feb 3, 2022
Merged

[MFTF] ZeroSubtotalOrdersWithProcessingStatusTest refactoring #33793

merged 3 commits into from
Feb 3, 2022

Conversation

AnnaAPak
Copy link
Contributor

Description (*)

The test is refactored according to the best practices

Related Pull Requests

#33727

Please, note: the test is dependent on #33727

@m2-assistant
Copy link

m2-assistant bot commented Aug 13, 2021

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Checkout Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 13, 2021
@AnnaAPak
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 28, 2021
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Nov 5, 2021

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Nov 24, 2021
@sidolov sidolov moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Nov 24, 2021
@sidolov sidolov changed the base branch from 2.4-develop to 2.0 November 24, 2021 19:24
@sidolov sidolov changed the base branch from 2.0 to 2.4-develop November 24, 2021 19:24
@m2-community-project m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Nov 24, 2021
@engcom-Alfa
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa
Copy link
Contributor

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa
Copy link
Contributor

@magento run WebAPI Tests, Unit Tests, Static Tests, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Magento Health Index, Integration Tests, Database Compare, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa
Copy link
Contributor

The PR auto-tests are continuously failing in as per my prior executions.
Hence moving the ticket to Extended Testing.

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 10, 2021
@engcom-Charlie engcom-Charlie self-assigned this Jan 6, 2022
@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Jan 6, 2022
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jan 6, 2022
@engcom-Alfa
Copy link
Contributor

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Jan 6, 2022
@engcom-Charlie
Copy link
Contributor

Hi @AnnaAPak,

Thank you for your contribution!

The build is green now and the test cases from the PR are working fine on local environment too. Hence moving this PR to Merge in Progress.

Thank you.

@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Jan 10, 2022
@sidolov sidolov mentioned this pull request Feb 3, 2022
Merged
1 task
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 3, 2022
@sidolov
ENGCOM-9350: [MFTF] ZeroSubtotalOrdersWithProcessingStatusTest refact…
d542fd8 
…oring #33793
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit e354f7c into magento:2.4-develop Feb 3, 2022
@sidolov sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Component: Checkout Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AnnaAPak @engcom-Alfa @engcom-Charlie @sidolov @magento-engcom-team @magento-devops-reposync-svc