Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Adding AdminCheckOrderStatusInGridActionGroup #33727

Merged
merged 4 commits into from
Nov 12, 2021
Merged

[MFTF] Adding AdminCheckOrderStatusInGridActionGroup #33727

merged 4 commits into from
Nov 12, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Aug 9, 2021 •
edited by m2-assistant bot
Loading

Description (*)

New ActionGroup AdminCheckOrderStatusInGridActionGroup has been introduced (existing tests have been updated as well)

Resolved issues:

  1. resolves [Issue] [MFTF] Adding AdminCheckOrderStatusInGridActionGroup #33747: [MFTF] Adding AdminCheckOrderStatusInGridActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Aug 9, 2021

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 9, 2021
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Aug 9, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13 eduard13 self-assigned this Aug 11, 2021
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Aug 11, 2021
@eduard13 eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 11, 2021
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Aug 11, 2021
@eduard13
Copy link
Contributor

@magento run Database Compare, Magento Health Index, Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE, Unit Tests, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 11, 2021
Closed
@eduard13
Copy link
Contributor

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

This was referenced Aug 12, 2021
Merged
Open
Den4ik
Den4ik approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnaAPak Changes looks good for me

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in High Priority Pull Requests Dashboard Aug 13, 2021
@engcom-Charlie engcom-Charlie self-assigned this Aug 18, 2021
@sidolov sidolov moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Sep 23, 2021
@sidolov
Copy link
Contributor

sidolov commented Oct 14, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov moved this from Merge in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Oct 14, 2021
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

Hi @AnnaAPak,

Thank you for your contribution!

I am looking into the conflicts and the build failures.

Thank you!

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

I have updated this PR branch with latest 2.4 develop code. Now, one test is failing and I have checked that the test case which is failing here is not part of this PR changes. Or not failing because of any changes made in this PR.

Hence, moving this to Merge in Progress.

Thank you!

@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Oct 28, 2021
magento-engcom-team pushed a commit that referenced this pull request Nov 12, 2021
@sidolov
ENGCOM-9181: [MFTF] Adding AdminCheckOrderStatusInGridActionGroup #33727
20be4aa
@magento-engcom-team magento-engcom-team merged commit e780caf into magento:2.4-develop Nov 12, 2021
@ihor-sviziev ihor-sviziev moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Nov 15, 2021
@sidolov sidolov added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 3, 2022
@sidolov
Copy link
Contributor

sidolov commented Feb 3, 2022

Hi @AnnaAPak. Thank you for your report.
The issue has been fixed in #33793 by @AnnaAPak in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@eduard13 eduard13

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Adding AdminCheckOrderStatusInGridActionGroup
7 participants
@AnnaAPak @andrewbess @eduard13 @magento-engcom-team @sidolov @engcom-Charlie @Den4ik