[33099] Set admin field as required while creating Visual Swatch attribute

[Usik2203]

Description (*)

Based on exception in console with message "Admin is a required field in each row" admin is a required field.
This PR set admin field as required

Actual result

Fixed Issues (if relevant)

1. Fixes Not showing error message when create attribute at product page #33099

Manual testing scenarios (*)

1. Admin -> Catalog -> Product -> Add new product -> Add Attribute -> Create New Attribute
2. Fill Attribute Label -> Choose Catalog Input Type for Store Owner is Vitual Swatch -> Manage Swatch -> Add Swatch -> Fill Default Store View -> Save Attribute

[m2-assistant]

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Usik2203]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[shikhamis11]

@Usik2203 thank you for your Pull request. It seems a similar error message is showing for Text Swatch too, Would you mind fixing it for Text Swatches as well ? Also Please cover your changes with MFTF test.

[shikhamis11]

#33795 (comment)

[engcom-Bravo]

@Usik2203 @shikhamis11 Thanks for your contribution!
@Usik2203 I am working on the requested changes.

[engcom-Bravo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Bravo]

Hi @shikhamis11 ,

I have worked on the requested changes by you.

Requesting you for review.

Thank You!

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Have a Magento latest instance installed with sample data

Manual testing scenario:

1. Admin - Catalog - Product - Click on Create a new simple product.

2. Click on "New Attribute" button from the Product form page.

3. Try to create new configuration attribute with the type "Text Swatch" or "Visual Swatch" keeping admin field empty.

Before: ✖️ Admin field was not being validated while creating a new attribute from new product creation page

After: ✔️ Admin field is being validated while creating a new attribute from new product creation page

There is no impact on any other feature since it is relevant to a particular field validation in the UI. Also cross checked that the automation failures is not because of PR changes!

[engcom-Charlie]

It seems that bot automatically moved this PR from Extended Testing to Ready for testing, so moving back to Extended Testing.

[engcom-Charlie]

The test case which is failing in this build is related to currency converter API. The build failure is not because of the PR changes and hence moving this to Merge in Progress.

Thank you!

[ishakhsuvarov]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ishakhsuvarov]

@magento run Functional Tests CE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.